<div dir="ltr">The test fails on Windows:<div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr"><strong>From: </strong>Richard Smith via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>></span><br><strong>Date: </strong>Fri, May 17, 2019 at 3:58 AM<br><strong>To: </strong> <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>><br><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: rsmith<br>
Date: Fri May 17 01:01:34 2019<br>
New Revision: 360998<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=360998&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=360998&view=rev</a><br>
Log:<br>
Fix crash if, during evaluation of __builtin_object_size, we try to load<br>
through an invalid base.<br>
<br>
Modified:<br>
    cfe/trunk/lib/AST/ExprConstant.cpp<br>
    cfe/trunk/test/SemaCXX/builtin-object-size-cxx14.cpp<br>
<br>
Modified: cfe/trunk/lib/AST/ExprConstant.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ExprConstant.cpp?rev=360998&r1=360997&r2=360998&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ExprConstant.cpp?rev=360998&r1=360997&r2=360998&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/AST/ExprConstant.cpp (original)<br>
+++ cfe/trunk/lib/AST/ExprConstant.cpp Fri May 17 01:01:34 2019<br>
@@ -3285,6 +3285,11 @@ static bool AreElementsOfSameArray(QualT<br>
 static CompleteObject findCompleteObject(EvalInfo &Info, const Expr *E,<br>
                                          AccessKinds AK, const LValue &LVal,<br>
                                          QualType LValType) {<br>
+  if (LVal.InvalidBase) {<br>
+    Info.FFDiag(E);<br>
+    return CompleteObject();<br>
+  }<br>
+<br>
   if (!LVal.Base) {<br>
     Info.FFDiag(E, diag::note_constexpr_access_null) << AK;<br>
     return CompleteObject();<br>
<br>
Modified: cfe/trunk/test/SemaCXX/builtin-object-size-cxx14.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/builtin-object-size-cxx14.cpp?rev=360998&r1=360997&r2=360998&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/builtin-object-size-cxx14.cpp?rev=360998&r1=360997&r2=360998&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/SemaCXX/builtin-object-size-cxx14.cpp (original)<br>
+++ cfe/trunk/test/SemaCXX/builtin-object-size-cxx14.cpp Fri May 17 01:01:34 2019<br>
@@ -97,3 +97,10 @@ void tooSmallBuf() {<br>
   copy5CharsIntoStrict(small.buf); // expected-error{{no matching function for call}}<br>
 }<br>
 }<br>
+<br>
+namespace InvalidBase {<br>
+  // Ensure this doesn't crash.<br>
+  struct S { const char *name; };<br>
+  S invalid_base();<br>
+  constexpr long bos_name = __builtin_object_size(invalid_base().name, 1);<br>
+}<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>