<div dir="auto">Thanks for the revert and the reduced test case.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 13 May 2019, 07:50 Hans Wennborg via cfe-commits, <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Here's a creduced repro:<br>
<br>
--<br>
class a {};<br>
class b : virtual a {<br>
  virtual bool c(const void *, int);<br>
};<br>
class C : b {<br>
public:<br>
  bool c(const void *, int);<br>
};<br>
int d;<br>
bool e() {<br>
  C f;<br>
  if (f.c(&d, d))<br>
    ;<br>
}<br>
--<br>
<br>
$ clang.bad -cc1 -triple x86_64-unknown-linux-gnu -fsyntax-only -std=c++14 a.cc<br>
<br>
The assert goes away if invoking clang with -w.<br>
<br>
From: Hans Wennborg <<a href="mailto:hans@chromium.org" target="_blank" rel="noreferrer">hans@chromium.org</a>><br>
Date: Mon, May 13, 2019 at 3:16 PM<br>
To: Richard Smith<br>
Cc: cfe-commits<br>
<br>
> This caused asserts in Chromium, so I've reverted in r360580. There's<br>
> a repro at <a href="https://bugs.chromium.org/p/chromium/issues/detail?id=962458#c1" rel="noreferrer noreferrer" target="_blank">https://bugs.chromium.org/p/chromium/issues/detail?id=962458#c1</a>,<br>
> and I'm working on a reduced version.<br>
><br>
> From: Richard Smith via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" rel="noreferrer">cfe-commits@lists.llvm.org</a>><br>
> Date: Mon, May 13, 2019 at 9:39 AM<br>
> To: <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" rel="noreferrer">cfe-commits@lists.llvm.org</a>><br>
><br>
> > Author: rsmith<br>
> > Date: Mon May 13 00:42:10 2019<br>
> > New Revision: 360559<br>
> ><br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project?rev=360559&view=rev" rel="noreferrer noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=360559&view=rev</a><br>
> > Log:<br>
> > [c++20] P1064R0: Allow virtual function calls in constant expression<br>
> > evaluation.<br>
> ><br>
> > Modified:<br>
> >     cfe/trunk/include/clang/AST/DeclCXX.h<br>
> >     cfe/trunk/include/clang/Basic/DiagnosticASTKinds.td<br>
> >     cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td<br>
> >     cfe/trunk/include/clang/Sema/Sema.h<br>
> >     cfe/trunk/lib/AST/DeclCXX.cpp<br>
> >     cfe/trunk/lib/AST/ExprConstant.cpp<br>
> >     cfe/trunk/lib/Sema/SemaDeclCXX.cpp<br>
> >     cfe/trunk/lib/Sema/SemaTemplateInstantiate.cpp<br>
> >     cfe/trunk/test/CXX/dcl.dcl/dcl.spec/dcl.constexpr/p3.cpp<br>
> >     cfe/trunk/test/CXX/drs/dr18xx.cpp<br>
> >     cfe/trunk/test/CXX/drs/dr6xx.cpp<br>
> >     cfe/trunk/test/SemaCXX/constant-expression-cxx2a.cpp<br>
> >     cfe/trunk/test/SemaCXX/cxx17-compat.cpp<br>
> >     cfe/trunk/www/cxx_status.html<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" rel="noreferrer">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>