<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr"><strong>From: </strong>MyDeveloperDay via Phabricator <span dir="ltr"><<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>></span><br><strong>Date: </strong>Fri, May 10, 2019 at 12:30 PM<br><strong>To: </strong> <<a href="mailto:velocityra@gmail.com">velocityra@gmail.com</a>>, <<a href="mailto:djasper@google.com">djasper@google.com</a>>, <<a href="mailto:klimek@google.com">klimek@google.com</a>>, <<a href="mailto:krasimir@google.com">krasimir@google.com</a>>, <<a href="mailto:sammccall@google.com">sammccall@google.com</a>>, <<a href="mailto:eknyquist@gmail.com">eknyquist@gmail.com</a>><br><strong>Cc: </strong> <<a href="mailto:jkorous@apple.com">jkorous@apple.com</a>>, <<a href="mailto:gardner48@llnl.gov">gardner48@llnl.gov</a>>, <<a href="mailto:fgross@noexcept.net">fgross@noexcept.net</a>>, <<a href="mailto:marcosbento@gmail.com">marcosbento@gmail.com</a>>, <<a href="mailto:lambdasnow@gmail.com">lambdasnow@gmail.com</a>>, <<a href="mailto:dougpuob@gmail.com">dougpuob@gmail.com</a>>, <<a href="mailto:shua2727@gmail.com">shua2727@gmail.com</a>>, <<a href="mailto:jacob.keller@gmail.com">jacob.keller@gmail.com</a>>, <<a href="mailto:mikel@mikelward.com">mikel@mikelward.com</a>>, <<a href="mailto:vit9696@avp.su">vit9696@avp.su</a>>, <<a href="mailto:razielmine@gmail.com">razielmine@gmail.com</a>>, <<a href="mailto:jgregory@atiba.com">jgregory@atiba.com</a>>, <<a href="mailto:mydeveloperday@gmail.com">mydeveloperday@gmail.com</a>>, <<a href="mailto:bob_basketbal@hotmail.com">bob_basketbal@hotmail.com</a>>, <<a href="mailto:bderickson%2Bllvmorg@gmail.com">bderickson+llvmorg@gmail.com</a>>, <<a href="mailto:anantha.keshava.bs@gmail.com">anantha.keshava.bs@gmail.com</a>>, <<a href="mailto:veegee@veegee.org">veegee@veegee.org</a>>, <<a href="mailto:alexandro@phi.nz">alexandro@phi.nz</a>>, <<a href="mailto:micasnyd@cisco.com">micasnyd@cisco.com</a>>, <<a href="mailto:up752724@myport.ac.uk">up752724@myport.ac.uk</a>>, <<a href="mailto:erik.johnson@live.ca">erik.johnson@live.ca</a>>, <<a href="mailto:lassi.niemisto@gmail.com">lassi.niemisto@gmail.com</a>>, <<a href="mailto:tiena2cva@gmail.com">tiena2cva@gmail.com</a>>, <<a href="mailto:marcos.horro@udc.es">marcos.horro@udc.es</a>>, <<a href="mailto:timothee.fivaz@gmail.com">timothee.fivaz@gmail.com</a>>, <<a href="mailto:jorisaerts@gmail.com">jorisaerts@gmail.com</a>>, <<a href="mailto:katya.romanova@sony.com">katya.romanova@sony.com</a>>, <scott@chickadee.tech>, <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>>, <<a href="mailto:wdietz2@illinois.edu">wdietz2@illinois.edu</a>>, <<a href="mailto:mzeren@vmware.com">mzeren@vmware.com</a>>, <<a href="mailto:zarevucky.jiri@gmail.com">zarevucky.jiri@gmail.com</a>>, <<a href="mailto:mdaniels2@apple.com">mdaniels2@apple.com</a>>, <<a href="mailto:rian.sanderson@gmail.com">rian.sanderson@gmail.com</a>>, <<a href="mailto:mcuddie@gmail.com">mcuddie@gmail.com</a>>, <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>>, <<a href="mailto:caner_kose98@hotmail.com">caner_kose98@hotmail.com</a>><br><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">MyDeveloperDay added a comment.<br>
<br>
When I spoke with one of the code owners, they seemed to have a problem accepting this review based on there not being a general description/understanding of how this algorithm works.<br>
<br>
Having said that, all of the "AlignToken" based functions (alignConsecutiveXXXX) are hard to understand unless you take the AlignTokens() function as read, and just look at the Lambda.<br>
<br>
As a relative new comer, I find some areas of clang-format hard to understand, I tend to learn them as and when I need to, but the gist of AlignTokens is in its comment, but with comments like 'There is a non-obvious subtlety' probably means you really need to be in it and inside a debugger to see what is going on.<br>
<br>
For this review I actually don't personally see what is Macro specific about AlignMacroSequence(), it seems to be almost identical to AlignTokenSequence without the scope and comment handling, (which actually makes it a lot simpler), my feeling is it could be used for more than just this, maybe pulling this out into its own set of functions wasn't the correct thing to do, and actually the original design might have been better, but this solution seems more simplistic and because its isolated means it doesn't break the other functions.<br>
<br>
All I feel I can add to the review process, is that perhaps a few more comments explaining the subtlety of the various "if statements" in both the Lambda and in the main alignment might help bring some clarify..</blockquote><div><br></div><div>That is basically what I thought.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> but to be honest I'm OK with how it works and I'd like it in.<br>
<br>
Ultimately I'd also like to see this revision land, especially as its off by default, I would like to see some ability to be able to set a Minimum Column distance to the value (this would allow Visual Studio to not keep playing the hokey-cokey (<a href="https://en.wikipedia.org/wiki/Hokey_cokey" rel="noreferrer" target="_blank">https://en.wikipedia.org/wiki/Hokey_cokey</a>) with resource.h files.), but perhaps that is for a later change once this is accepted.<br>
<br>
>From my perspective it LGTM, if the code owners are present they should really rubber stamp it, If not well...<br></blockquote><div><br></div><div>If you believe you understand this code well enough to LG it, I'm fine with it going in. I think we need one reviewer spending enough to time understand why the code is the way it is, and given the quality of code I've seen from you, I do trust your ability to understand code :)</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://reviews.llvm.org/D28462/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D28462/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D28462" rel="noreferrer" target="_blank">https://reviews.llvm.org/D28462</a><br>
<br>
<br>
<br>
</blockquote></div></div>