<div dir="ltr">Thanks for the fix Nico!</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Apr 21, 2019 at 9:17 PM Nico Weber <<a href="mailto:thakis@chromium.org">thakis@chromium.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>r358858 might help with this.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Apr 20, 2019 at 7:15 PM Nico Weber <<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr">This breaks building with LLVM_ENABLE_THREADS=OFF. The call probably needs to be behind a `#if LLVM_ENABLE_THREADS`.</div><div dir="ltr"><br></div><div dir="ltr"><div dir="ltr">FAILED: bin/c-index-test </div><div dir="ltr">...</div><div dir="ltr">lib/libclang.a(CIndex.cpp.o): In function `void llvm::function_ref<void ()>::callback_fn<clang_saveTranslationUnit::{lambda()#1}>(long)':</div><div dir="ltr">CIndex.cpp:(.text._ZN4llvm12function_refIFvvEE11callback_fnIZ25clang_saveTranslationUnitEUlvE_EEvl+0x5a): undefined reference to `llvm::set_thread_priority(llvm::ThreadPriority)'</div><div dir="ltr">lib/libclang.a(CIndex.cpp.o): In function `clang::setThreadBackgroundPriority()':</div><div dir="ltr">CIndex.cpp:(.text._ZN5clang27setThreadBackgroundPriorityEv+0x27): undefined reference to `llvm::set_thread_priority(llvm::ThreadPriority)'</div><div dir="ltr">lib/libclang.a(CIndex.cpp.o): In function `clang_saveTranslationUnit':</div><div dir="ltr">CIndex.cpp:(.text.clang_saveTranslationUnit+0x316): undefined reference to `llvm::set_thread_priority(llvm::ThreadPriority)'</div></div><div dir="ltr"><br></div></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 18, 2019 at 9:47 AM Kadir Cetinkaya via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: kadircet<br>
Date: Thu Apr 18 06:49:20 2019<br>
New Revision: 358665<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=358665&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=358665&view=rev</a><br>
Log:<br>
[clang][CIndex] Use llvm::set_thread_priority<br>
<br>
Reviewers: jkorous, gribozavr<br>
<br>
Subscribers: dexonsmith, arphaman, cfe-commits<br>
<br>
Tags: #clang<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D60867" rel="noreferrer" target="_blank">https://reviews.llvm.org/D60867</a><br>
<br>
Modified:<br>
    cfe/trunk/tools/libclang/CIndex.cpp<br>
<br>
Modified: cfe/trunk/tools/libclang/CIndex.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/libclang/CIndex.cpp?rev=358665&r1=358664&r2=358665&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/libclang/CIndex.cpp?rev=358665&r1=358664&r2=358665&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/tools/libclang/CIndex.cpp (original)<br>
+++ cfe/trunk/tools/libclang/CIndex.cpp Thu Apr 18 06:49:20 2019<br>
@@ -8723,9 +8723,7 @@ void clang::setThreadBackgroundPriority(<br>
   if (getenv("LIBCLANG_BGPRIO_DISABLE"))<br>
     return;<br>
<br>
-#ifdef USE_DARWIN_THREADS<br>
-  setpriority(PRIO_DARWIN_THREAD, 0, PRIO_DARWIN_BG);<br>
-#endif<br>
+  llvm::set_thread_priority(llvm::ThreadPriority::Background);<br>
 }<br>
<br>
 void cxindex::printDiagsToStderr(ASTUnit *Unit) {<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>
</blockquote></div>
</blockquote></div>