<div dir="ltr">Why would we want this to be different in Obj-C and C++?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 4, 2019 at 9:34 AM Krasimir Georgiev via Phabricator via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">krasimir marked 2 inline comments as done.<br>
krasimir added inline comments.<br>
<br>
<br>
================<br>
Comment at: lib/Format/Format.cpp:787<br>
   GoogleStyle.IncludeStyle.IncludeIsMainRegex = "([-_](test|unittest))?$";<br>
   GoogleStyle.IncludeStyle.IncludeBlocks = tooling::IncludeStyle::IBS_Regroup;<br>
   GoogleStyle.IndentCaseLabels = true;<br>
----------------<br>
ioeric wrote:<br>
> maybe we should also only use regroup for cpp? `regroup` is only supported in `sortCppIncludes` after all.<br>
Yeah, but they are just not used for unrelated languages. This argument applies to the other fields in the IncludeStyle group above this. I'd lean on keeping this as-is.<br>
<br>
<br>
Repository:<br>
  rC Clang<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D60263/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D60263/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D60263" rel="noreferrer" target="_blank">https://reviews.llvm.org/D60263</a><br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>