<div dir="ltr"><div dir="ltr">Thanks! I committed the fix in r357740. The test should start passing now.</div><div dir="ltr"><br></div><div>Cheers,</div><div>Alex</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 4 Apr 2019 at 18:32, Stephen Hines <<a href="mailto:srhines@google.com">srhines@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Ah I just saw this. Please feel free to CC me on the fix CL and I will<br>
approve it. I didn't realize that the exact specification was missing<br>
for that.<br>
<br>
Thanks,<br>
Steve<br>
<br>
On Thu, Apr 4, 2019 at 6:31 PM Alex L <<a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>> wrote:<br>
><br>
> Thanks, for the explanation, it makes sense. It looks like an explicit `darwin14` in one of the non-versioned darwin triples fixes the issue. I will commit the fix right away.<br>
><br>
> Cheers,<br>
> Alex<br>
><br>
><br>
> On Thu, 4 Apr 2019 at 18:24, Adrian Prantl <<a href="mailto:aprantl@apple.com" target="_blank">aprantl@apple.com</a>> wrote:<br>
>><br>
>> IIRC, the dwarf version on Darwin depends on the deployment target and is 2 for earlier versions of macOS and and 4 for newer ones (I need to dig through the driver code to determine the exact version).<br>
>><br>
>> I can take a look at this tomorrow morning.<br>
>><br>
>> -- adrian<br>
>><br>
>> On Apr 4, 2019, at 6:21 PM, Alex L <<a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>> wrote:<br>
>><br>
>> Hi Stephen,<br>
>><br>
>> It looks like your change has caused the 'debug-options.c' test to start failing on Darwin. It looks like we emit "-dwarf-version=4" by default, and not 2. Could you please take a look.<br>
>><br>
>> Here's a link to a latest build on the public LLVM CI that contains the failure:<br>
>> <a href="http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental/59772/console" rel="noreferrer" target="_blank">http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental/59772/console</a><br>
>><br>
>> Here's the failure itself:<br>
>> Command Output (stderr): -- /Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/llvm/tools/clang/test/Driver/debug-options.c:280:14: error: G_DWARF2: expected string not found in input // G_DWARF2: "-dwarf-version=2" ^ <stdin>:5:515: note: scanning from here "/Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/clang-build/bin/clang-9" "-cc1" "-triple" "x86_64-apple-macosx10.13.0" "-Wdeprecated-objc-isa-usage" "-Werror=deprecated-objc-isa-usage" "-emit-obj" "-mrelax-all" "-disable-free" "-main-file-name" "debug-options.c" "-mrelocation-model" "pic" "-pic-level" "2" "-mthread-model" "posix" "-mdisable-fp-elim" "-masm-verbose" "-munwind-tables" "-faligned-alloc-unavailable" "-target-cpu" "penryn" "-dwarf-column-info" "-debug-info-kind=standalone" "-dwarf-version=4" "-debugger-tuning=lldb" "-ggnu-pubnames" "-target-linker-version" "351.8" "-coverage-notes-file" "/Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/clang-build/tools/clang/test/Driver/debug-options.gcno" "-resource-dir" "/Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/clang-build/lib/clang/9.0.0" "-fdebug-compilation-dir" "/Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/clang-build/tools/clang/test/Driver" "-ferror-limit" "19" "-fmessage-length" "0" "-stack-protector" "1" "-fblocks" "-fencode-extended-block-signature" "-fregister-global-dtors-with-atexit" "-fobjc-runtime=macosx-10.13.0" "-fmax-type-align=16" "-fdiagnostics-show-option" "-o" "debug-options.o" "-x" "c" "/Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/llvm/tools/clang/test/Driver/debug-options.c" ^<br>
>><br>
>><br>
>> Adrian, I've looped you in since you reviewed the commit it looks like. Do you know if that's expected behavior on Darwin?<br>
>><br>
>> Cheers,<br>
>> Alex<br>
>><br>
>> On Thu, 4 Apr 2019 at 11:16, Stephen Hines via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br>
>>><br>
>>> Author: srhines<br>
>>> Date: Thu Apr 4 11:17:46 2019<br>
>>> New Revision: 357713<br>
>>><br>
>>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=357713&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=357713&view=rev</a><br>
>>> Log:<br>
>>> Verify that Android targets generate DWARF 4 by default.<br>
>>><br>
>>> Summary:<br>
>>> In the future, Android releases will support DWARF 5, but we need to<br>
>>> ensure that older targets only have DWARF 4 generated for them. This<br>
>>> patch inserts that verification for all Android releases now. The patch<br>
>>> also fixes 2 minor mistakes (a mistakenly moved RUN line, and the<br>
>>> missing G_DWARF2 check label).<br>
>>><br>
>>> Reviewers: aprantl<br>
>>><br>
>>> Reviewed By: aprantl<br>
>>><br>
>>> Subscribers: chh, pirama, cfe-commits<br>
>>><br>
>>> Tags: #clang<br>
>>><br>
>>> Differential Revision: <a href="https://reviews.llvm.org/D60238" rel="noreferrer" target="_blank">https://reviews.llvm.org/D60238</a><br>
>>><br>
>>> Modified:<br>
>>> cfe/trunk/test/Driver/debug-options.c<br>
>>><br>
>>> Modified: cfe/trunk/test/Driver/debug-options.c<br>
>>> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/debug-options.c?rev=357713&r1=357712&r2=357713&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/debug-options.c?rev=357713&r1=357712&r2=357713&view=diff</a><br>
>>> ==============================================================================<br>
>>> --- cfe/trunk/test/Driver/debug-options.c (original)<br>
>>> +++ cfe/trunk/test/Driver/debug-options.c Thu Apr 4 11:17:46 2019<br>
>>> @@ -17,9 +17,14 @@<br>
>>> // RUN: %clang -### -c -glldb %s -target x86_64-linux-gnu 2>&1 \<br>
>>> // RUN: | FileCheck -check-prefix=G -check-prefix=G_LLDB %s<br>
>>> // RUN: %clang -### -c -gsce %s -target x86_64-linux-gnu 2>&1 \<br>
>>> +// RUN: | FileCheck -check-prefix=G -check-prefix=G_SCE %s<br>
>>> +<br>
>>> +// Android.<br>
>>> +// Android should always generate DWARF4.<br>
>>> +// RUN: %clang -### -c -g %s -target arm-linux-androideabi 2>&1 \<br>
>>> +// RUN: | FileCheck -check-prefix=G -check-prefix=G_DWARF4 %s<br>
>>><br>
>>> // Darwin.<br>
>>> -// RUN: | FileCheck -check-prefix=G -check-prefix=G_SCE %s<br>
>>> // RUN: %clang -### -c -g %s -target x86_64-apple-darwin 2>&1 \<br>
>>> // RUN: | FileCheck -check-prefix=G_STANDALONE \<br>
>>> // RUN: -check-prefix=G_DWARF2 \<br>
>>> @@ -272,6 +277,7 @@<br>
>>> //<br>
>>> // G_STANDALONE: "-cc1"<br>
>>> // G_STANDALONE: "-debug-info-kind=standalone"<br>
>>> +// G_DWARF2: "-dwarf-version=2"<br>
>>> // G_DWARF4: "-dwarf-version=4"<br>
>>> //<br>
>>> // G_GDB: "-debugger-tuning=gdb"<br>
>>><br>
>>><br>
>>> _______________________________________________<br>
>>> cfe-commits mailing list<br>
>>> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
>>> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
>><br>
>><br>
</blockquote></div>