<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Thanks. Any idea why AtomicChange.cpp's inclusion of <span style="color:rgb(3,47,98);font-family:SFMono-Regular,Consolas,"Liberation Mono",Menlo,Courier,monospace;font-size:12px;white-space:pre">clang/Tooling/ReplacementsYaml.h </span>doesn't cause the same problem?</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><a href="https://github.com/llvm/llvm-project/blob/master/clang/lib/Tooling/Refactoring/AtomicChange.cpp">https://github.com/llvm/llvm-project/blob/master/clang/lib/Tooling/Refactoring/AtomicChange.cpp</a><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 3, 2019 at 2:11 PM Alexey Bataev <<a href="mailto:a.bataev@outlook.com">a.bataev@outlook.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF">
<p>The problem is that libToolingRefactor is a part of libTooling.
And you have the dependency from the Tooling/Refactor subdirectory
to the outer one Tooling/ directory. And it means that
libToolingRefactor is a part of libTooling, but it must depend on
libTooling itself.<br>
</p>
<pre class="gmail-m_-5742630031947972622moz-signature" cols="72">-------------
Best regards,
Alexey Bataev</pre>
<div class="gmail-m_-5742630031947972622moz-cite-prefix">03.04.2019 14:08, Yitzhak Mandelbaum
пишет:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Alexey, thanks
for reverting the change. Can you expand on why a dependency
from libToolingRefactor to libTooling causes a cycle in the
dep graph? In particular, I can't find the reverse dependency
libTooling -> libToolingRefactor. If you can expand on that
(I presume its a chain rather than a direct dependency?) that
would be really helpful.</div>
<div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br>
</div>
<div class="gmail_default" style="font-family:arial,helvetica,sans-serif">thanks!</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Wed, Apr 3, 2019 at 1:29 PM
Yitzhak Mandelbaum <<a href="mailto:yitzhakm@google.com" target="_blank">yitzhakm@google.com</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div class="gmail_default" style="font-family:arial,helvetica,sans-serif">I'll revert
the change.</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Wed, Apr 3, 2019 at
1:00 PM Yitzhak Mandelbaum <<a href="mailto:yitzhakm@google.com" target="_blank">yitzhakm@google.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><a href="https://reviews.llvm.org/D60213" target="_blank">https://reviews.llvm.org/D60213</a> for
the record<br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Wed, Apr 3, 2019 at
12:55 PM Yitzhak Mandelbaum <<a href="mailto:yitzhakm@google.com" target="_blank">yitzhakm@google.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Thanks.
Do you have build command I can run before/after
to verify my fix before I submit?</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Wed, Apr 3,
2019 at 12:43 PM Alexey Bataev via Phabricator
<<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">ABataev added a
comment.<br>
<br>
Patch breaks the build with the shared libraries,
for example, <a href="http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage/builds/9498" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage/builds/9498</a>.
Seems to me, you need to add an extra dependency
on clangTooling. clangToolingCore is not enough.<br>
<br>
<br>
Repository:<br>
rC Clang<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://reviews.llvm.org/D59376/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D59376/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D59376" rel="noreferrer" target="_blank">https://reviews.llvm.org/D59376</a><br>
<br>
<br>
<br>
</blockquote>
</div>
</blockquote>
</div>
</blockquote>
</div>
</blockquote>
</div>
</blockquote>
</div>
</blockquote></div>