<div dir="ltr"><div dir="ltr"></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Apr 2, 2019 at 10:53 AM Mikael Holmén via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">uabelho added a comment.<br>
<br>
Hi,<br>
<br>
I noticed that with this commit I get a whole bunch (~40) of warnings like the below when compiling with gcc 7.4:<br>
<br>
  [10/16] Building CXX object tools/clang/tools/extra/clang-tidy/utils/CMakeFiles/clangTidyUtils.dir/HeaderGuard.cpp.o<br>
  In file included from ../tools/clang/tools/extra/clang-tidy/utils/HeaderGuard.h:12:0,<br>
                   from ../tools/clang/tools/extra/clang-tidy/utils/HeaderGuard.cpp:9:<br>
  ../tools/clang/tools/extra/clang-tidy/utils/../ClangTidy.h:161:16: warning: 'virtual void clang::tidy::ClangTidyCheck::registerPPCallbacks(const clang::SourceManager&, clang::Preprocessor*, clang::Preprocessor*)' was hidden [-Woverloaded-virtual]<br>
     virtual void registerPPCallbacks(const SourceManager &SM, Preprocessor *PP,<br>
                  ^~~~~~~~~~~~~~~~~~~<br>
  In file included from ../tools/clang/tools/extra/clang-tidy/utils/HeaderGuard.cpp:9:0:<br>
  ../tools/clang/tools/extra/clang-tidy/utils/HeaderGuard.h:35:8: warning:   by 'virtual void clang::tidy::utils::HeaderGuardCheck::registerPPCallbacks(clang::CompilerInstance&)' [-Woverloaded-virtual]<br>
     void registerPPCallbacks(CompilerInstance &Compiler) override;<br>
          ^~~~~~~~~~~~~~~~~~~<br>
<br>
One of the registerPPCallbacks methods has the following comment<br>
<br>
  /// DEPRECATED: Use the other overload.<br>
  virtual void registerPPCallbacks(CompilerInstance &Compiler) {}<br>
<br>
so I suppose it will be removed at some point?<br></blockquote><div><br></div><div>Indeed, the plan is to remove the old overload.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
I'm not super familiar with the warning, but there is at least one discussion about it here:<br>
<a href="https://stackoverflow.com/questions/9995421/gcc-woverloaded-virtual-warnings" rel="noreferrer" target="_blank">https://stackoverflow.com/questions/9995421/gcc-woverloaded-virtual-warnings</a><br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D59528/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D59528/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D59528" rel="noreferrer" target="_blank">https://reviews.llvm.org/D59528</a><br>
<br>
<br>
<br>
</blockquote></div></div>