<div dir="ltr">Thanks for fixing this!</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Apr 1, 2019 at 11:14 PM Reid Kleckner via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: rnk<br>
Date: Mon Apr  1 14:16:17 2019<br>
New Revision: 357429<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=357429&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=357429&view=rev</a><br>
Log:<br>
Fix clangd unittest _WIN32 ifdef<br>
<br>
WIN32 is not defined, _WIN32 is, use that instead.<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/unittests/clangd/JSONTransportTests.cpp<br>
<br>
Modified: clang-tools-extra/trunk/unittests/clangd/JSONTransportTests.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/unittests/clangd/JSONTransportTests.cpp?rev=357429&r1=357428&r2=357429&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/unittests/clangd/JSONTransportTests.cpp?rev=357429&r1=357428&r2=357429&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/unittests/clangd/JSONTransportTests.cpp (original)<br>
+++ clang-tools-extra/trunk/unittests/clangd/JSONTransportTests.cpp Mon Apr  1 14:16:17 2019<br>
@@ -17,8 +17,8 @@ namespace {<br>
<br>
 // No fmemopen on windows or on versions of MacOS X earlier than 10.13, so we<br>
 // can't easily run this test.<br>
-#if !(defined(WIN32) || (defined(__MAC_OS_X_VERSION_MIN_REQUIRED) &&           \<br>
-                         __MAC_OS_X_VERSION_MIN_REQUIRED < 101300))<br>
+#if !(defined(_WIN32) || (defined(__MAC_OS_X_VERSION_MIN_REQUIRED) &&          \<br>
+                          __MAC_OS_X_VERSION_MIN_REQUIRED < 101300))<br>
<br>
 // Fixture takes care of managing the input/output buffers for the transport.<br>
 class JSONTransportTest : public ::testing::Test {<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Regards,</div><div>Ilya Biryukov</div></div></div></div></div>