<div dir="ltr">Do we still need changes like this now that we have the /clang: switch?<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Mar 29, 2019 at 10:02 AM Hans Wennborg via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: hans<br>
Date: Fri Mar 29 07:03:34 2019<br>
New Revision: 357255<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=357255&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=357255&view=rev</a><br>
Log:<br>
clang-cl: Expose -fprofile-generate and -fcs-profile-generate (PR41252)<br>
<br>
Modified:<br>
    cfe/trunk/include/clang/Driver/Options.td<br>
    cfe/trunk/test/Driver/cl-options.c<br>
<br>
Modified: cfe/trunk/include/clang/Driver/Options.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=357255&r1=357254&r2=357255&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=357255&r1=357254&r2=357255&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Driver/Options.td (original)<br>
+++ cfe/trunk/include/clang/Driver/Options.td Fri Mar 29 07:03:34 2019<br>
@@ -742,16 +742,16 @@ def fno_coverage_mapping : Flag<["-"], "<br>
     Group<f_Group>, Flags<[DriverOption, CoreOption]>,<br>
     HelpText<"Disable code coverage analysis">;<br>
 def fprofile_generate : Flag<["-"], "fprofile-generate">,<br>
-    Group<f_Group>, Flags<[DriverOption]>,<br>
+    Group<f_Group>, Flags<[CoreOption]>,<br>
     HelpText<"Generate instrumented code to collect execution counts into default.profraw (overridden by LLVM_PROFILE_FILE env var)">;<br>
 def fprofile_generate_EQ : Joined<["-"], "fprofile-generate=">,<br>
-    Group<f_Group>, Flags<[DriverOption]>, MetaVarName<"<directory>">,<br>
+    Group<f_Group>, Flags<[CoreOption]>, MetaVarName<"<directory>">,<br>
     HelpText<"Generate instrumented code to collect execution counts into <directory>/default.profraw (overridden by LLVM_PROFILE_FILE env var)">;<br>
 def fcs_profile_generate : Flag<["-"], "fcs-profile-generate">,<br>
-    Group<f_Group>, Flags<[DriverOption]>,<br>
+    Group<f_Group>, Flags<[CoreOption]>,<br>
     HelpText<"Generate instrumented code to collect context sensitive execution counts into default.profraw (overridden by LLVM_PROFILE_FILE env var)">;<br>
 def fcs_profile_generate_EQ : Joined<["-"], "fcs-profile-generate=">,<br>
-    Group<f_Group>, Flags<[DriverOption]>, MetaVarName<"<directory>">,<br>
+    Group<f_Group>, Flags<[CoreOption]>, MetaVarName<"<directory>">,<br>
     HelpText<"Generate instrumented code to collect context sensitive execution counts into <directory>/default.profraw (overridden by LLVM_PROFILE_FILE env var)">;<br>
 def fprofile_use : Flag<["-"], "fprofile-use">, Group<f_Group>,<br>
     Alias<fprofile_instr_use>;<br>
@@ -759,13 +759,13 @@ def fprofile_use_EQ : Joined<["-"], "fpr<br>
     Group<f_Group>, Flags<[DriverOption]>, MetaVarName<"<pathname>">,<br>
     HelpText<"Use instrumentation data for profile-guided optimization. If pathname is a directory, it reads from <pathname>/default.profdata. Otherwise, it reads from file <pathname>.">;<br>
 def fno_profile_instr_generate : Flag<["-"], "fno-profile-instr-generate">,<br>
-    Group<f_Group>, Flags<[DriverOption]>,<br>
+    Group<f_Group>, Flags<[CoreOption]>,<br>
     HelpText<"Disable generation of profile instrumentation.">;<br>
 def fno_profile_generate : Flag<["-"], "fno-profile-generate">,<br>
-    Group<f_Group>, Flags<[DriverOption]>,<br>
+    Group<f_Group>, Flags<[CoreOption]>,<br>
     HelpText<"Disable generation of profile instrumentation.">;<br>
 def fno_profile_instr_use : Flag<["-"], "fno-profile-instr-use">,<br>
-    Group<f_Group>, Flags<[DriverOption]>,<br>
+    Group<f_Group>, Flags<[CoreOption]>,<br>
     HelpText<"Disable using instrumentation data for profile-guided optimization">;<br>
 def fno_profile_use : Flag<["-"], "fno-profile-use">,<br>
     Alias<fno_profile_instr_use>;<br>
<br>
Modified: cfe/trunk/test/Driver/cl-options.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/cl-options.c?rev=357255&r1=357254&r2=357255&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/cl-options.c?rev=357255&r1=357254&r2=357255&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/Driver/cl-options.c (original)<br>
+++ cfe/trunk/test/Driver/cl-options.c Fri Mar 29 07:03:34 2019<br>
@@ -630,6 +630,13 @@<br>
 // RUN:     -no-canonical-prefixes \<br>
 // RUN:     -march=skylake \<br>
 // RUN:     -fbracket-depth=123 \<br>
+// RUN:     -fprofile-generate \<br>
+// RUN:     -fprofile-generate=dir \<br>
+// RUN:     -fno-profile-generate \<br>
+// RUN:     -fno-profile-instr-generate \<br>
+// RUN:     -fno-profile-instr-use \<br>
+// RUN:     -fcs-profile-generate \<br>
+// RUN:     -fcs-profile-generate=dir \<br>
 // RUN:     --version \<br>
 // RUN:     -Werror /Zs -- %s 2>&1<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>