<div dir="ltr"><div dir="ltr">Thanks, this helped.<div><br></div><div>> to hopefully fix the chromium build.</div><div><br></div><div>I'd argue it's overall more sane. Single underscore followed by lower-case letters isn't reserved in non-global scope, so what gcc is doing isn't quite proper from what I understand.</div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Mar 24, 2019 at 1:58 PM Craig Topper via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: ctopper<br>
Date: Sun Mar 24 11:00:20 2019<br>
New Revision: 356862<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=356862&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=356862&view=rev</a><br>
Log:<br>
[X86] Make _bswap intrinsic a function instead of a macro to hopefully fix the chromium build.<br>
<br>
This intrinsic was added in r356848 but was implemented as a macro to match gcc.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Headers/ia32intrin.h<br>
<br>
Modified: cfe/trunk/lib/Headers/ia32intrin.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Headers/ia32intrin.h?rev=356862&r1=356861&r2=356862&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Headers/ia32intrin.h?rev=356862&r1=356861&r2=356862&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Headers/ia32intrin.h (original)<br>
+++ cfe/trunk/lib/Headers/ia32intrin.h Sun Mar 24 11:00:20 2019<br>
@@ -78,7 +78,11 @@ __bswapd(int __A) {<br>
   return __builtin_bswap32(__A);<br>
 }<br>
<br>
-#define _bswap(A) __bswapd((A))<br>
+static __inline__ int __attribute__((__always_inline__, __nodebug__))<br>
+_bswap(int __A) {<br>
+  return __builtin_bswap32(__A);<br>
+}<br>
+<br>
 #define _bit_scan_forward(A) __bsfd((A))<br>
 #define _bit_scan_reverse(A) __bsrd((A))<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>