<div dir="ltr">Hi Aaron,<br><br>I don't see any mention of this in D44406 - so it might have been good to have a separate review for this (or included this in the review of D44406, which I think is possible with the monorepo).<br><br>Specifically - this change is missing test coverage (there should be a clang test that goes from C++ source code to LLVM IR & demonstrates the flag being emitted into the IR, etc).<br><br>Also - what's the reason the non-triviality can't be implied by the absence of the trivial flag? (or the other way around) - the flags seem redundant with one another.<br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Feb 25, 2019 at 8:02 PM Aaron Smith via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: asmith<br>
Date: Mon Feb 25 19:49:05 2019<br>
New Revision: 354843<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=354843&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=354843&view=rev</a><br>
Log:<br>
[CGDebugInfo] Set NonTrivial DIFlag to a c++ record if it's not trivial<br>
<br>
This goes with <a href="https://reviews.llvm.org/D44406" rel="noreferrer" target="_blank">https://reviews.llvm.org/D44406</a><br>
<br>
<br>
Modified:<br>
    cfe/trunk/lib/CodeGen/CGDebugInfo.cpp<br>
<br>
Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=354843&r1=354842&r2=354843&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=354843&r1=354842&r2=354843&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/CodeGen/CGDebugInfo.cpp (original)<br>
+++ cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Mon Feb 25 19:49:05 2019<br>
@@ -3031,6 +3031,8 @@ llvm::DICompositeType *CGDebugInfo::Crea<br>
     // Record if a C++ record is trivial type.<br>
     if (CXXRD->isTrivial())<br>
       Flags |= llvm::DINode::FlagTrivial;<br>
+    else<br>
+      Flags |= llvm::DINode::FlagNonTrivial;<br>
   }<br>
<br>
   llvm::DICompositeType *RealDecl = DBuilder.createReplaceableCompositeType(<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div>