<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<div>
<div>
<div style="direction: ltr;">Hi David, I can take a look at adding another test. Please read the code review which answers your question. A new flag is required. Thanks.</div>
</div>
<div><br>
</div>
<div class="ms-outlook-ios-signature"></div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> David Blaikie <dblaikie@gmail.com><br>
<b>Sent:</b> Tuesday, March 5, 2019 12:51:27 AM<br>
<b>To:</b> Aaron Smith; Reid Kleckner; Adrian Prantl; Jonas Devlieghere<br>
<b>Cc:</b> cfe-commits@lists.llvm.org<br>
<b>Subject:</b> Re: r354843 - [CGDebugInfo] Set NonTrivial DIFlag to a c++ record if it's not trivial</font>
<div> </div>
</div>
<div>
<div dir="ltr">Hi Aaron,<br>
<br>
I don't see any mention of this in D44406 - so it might have been good to have a separate review for this (or included this in the review of D44406, which I think is possible with the monorepo).<br>
<br>
Specifically - this change is missing test coverage (there should be a clang test that goes from C++ source code to LLVM IR & demonstrates the flag being emitted into the IR, etc).<br>
<br>
Also - what's the reason the non-triviality can't be implied by the absence of the trivial flag? (or the other way around) - the flags seem redundant with one another.<br>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon, Feb 25, 2019 at 8:02 PM Aaron Smith via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: asmith<br>
Date: Mon Feb 25 19:49:05 2019<br>
New Revision: 354843<br>
<br>
URL: <a href="https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fllvm.org%2Fviewvc%2Fllvm-project%3Frev%3D354843%26view%3Drev&data=02%7C01%7Caaron.smith%40microsoft.com%7C9ee22645e4544a8a54a808d6a0b94a7a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636873115022346268&sdata=jkLruyBw16u7MYD8G0vjNH5BAmhJbUxWM0mGPctzhxE%3D&reserved=0" originalsrc="http://llvm.org/viewvc/llvm-project?rev=354843&view=rev" shash="wt4DHXuQPutb2A4viAPxHc/bn0S8ip0yzxuyAXt/k7oYRtf75qhExtiveDujzIdv59QQkB0tKpLBeZFGXs4gG29ujvDBSvEVDkiUg6lN9uSr7PebefahZ5F+BZfe2JfRGhmd4wIuv5vKbblY8oWbeNf5y3EWzi84QNrCRCaEnU4=" rel="noreferrer" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=354843&view=rev</a><br>
Log:<br>
[CGDebugInfo] Set NonTrivial DIFlag to a c++ record if it's not trivial<br>
<br>
This goes with <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD44406&data=02%7C01%7Caaron.smith%40microsoft.com%7C9ee22645e4544a8a54a808d6a0b94a7a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636873115022346268&sdata=YBPvy0l%2BVVCzPWSXB0VYUPRS2AVHOA6pGH0sKIfM6D4%3D&reserved=0" originalsrc="https://reviews.llvm.org/D44406" shash="acSpXEmFi3FksMR2cpL0JgiwU4FQAhaflfg4l7Dwub1+3oLuhbgqLuBZoPbOd299OCaeshJioLEKjgnEyDXOG4fO7vdSgAqIYaMz/f/BXLE5Y55D91q1z1uUqshS3TBcDaB0WZGeGfjSEcBrD08I+sJx1tiQNhoU46pvRNSzjw8=" rel="noreferrer" target="_blank">
https://reviews.llvm.org/D44406</a><br>
<br>
<br>
Modified:<br>
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp<br>
<br>
Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp<br>
URL: <a href="https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fllvm.org%2Fviewvc%2Fllvm-project%2Fcfe%2Ftrunk%2Flib%2FCodeGen%2FCGDebugInfo.cpp%3Frev%3D354843%26r1%3D354842%26r2%3D354843%26view%3Ddiff&data=02%7C01%7Caaron.smith%40microsoft.com%7C9ee22645e4544a8a54a808d6a0b94a7a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636873115022356269&sdata=jkg1JEzzsmEyAfaBggFOy84iEVR%2Foqn0y%2Fj1ohXQcVk%3D&reserved=0" originalsrc="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=354843&r1=354842&r2=354843&view=diff" shash="nymYM948wx6BiHq1ywW88FG2oKMk2d82pN1rPB4Pjz45zrfp9ltNAhaSp1n5tTGEKFMZUQ8Sn41BY/5CF6eiAm/TSgaFJm8gvz6Q8Wli77b00Q5XvvAz0YLXp+g0OUraAQQJk/jxMS8BhlJO6lcTb8HZmCHYS/chKsD5qh6Lx7A=" rel="noreferrer" target="_blank">
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=354843&r1=354842&r2=354843&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/CodeGen/CGDebugInfo.cpp (original)<br>
+++ cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Mon Feb 25 19:49:05 2019<br>
@@ -3031,6 +3031,8 @@ llvm::DICompositeType *CGDebugInfo::Crea<br>
// Record if a C++ record is trivial type.<br>
if (CXXRD->isTrivial())<br>
Flags |= llvm::DINode::FlagTrivial;<br>
+ else<br>
+ Flags |= llvm::DINode::FlagNonTrivial;<br>
}<br>
<br>
llvm::DICompositeType *RealDecl = DBuilder.createReplaceableCompositeType(<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.llvm.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fcfe-commits&data=02%7C01%7Caaron.smith%40microsoft.com%7C9ee22645e4544a8a54a808d6a0b94a7a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636873115022366259&sdata=yJtEfwH0KXKsMScvooRpNZGXiLshTqIRIwOBSoVxUio%3D&reserved=0" originalsrc="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" shash="kag0IiuBK8g6mxq8ZN1/ObNw7qXXS+6l2QpVAsTPQpzBqJAmwxkpiMNlz6TkiDoldkz6fNzfExesF/q1jkX8wF2JcLpW6tPqX6bYx1tLmemtrntR9IoUOefNKnersWOghMZewFi35n1vwrdO3X+ISM13TUkgdf3brco+JKlMBEw=" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote>
</div>
</div>
</div>
</body>
</html>