<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">No -- That was supposed to be a single commit. I used the git llvm push expecting it to commit the diff that I saw through arc diff, but instead got the four separate commits. I should have squashed the 4 (local) commits into a single commit beforehand but missed that step.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Should rollback those commits and redo as a single one?</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Feb 15, 2019 at 9:54 AM Roman Lebedev <<a href="mailto:lebedev.ri@gmail.com">lebedev.ri@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, Feb 15, 2019 at 5:42 PM Yitzhak Mandelbaum via cfe-commits<br>
<<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: ymandel<br>
> Date: Fri Feb 15 06:43:10 2019<br>
> New Revision: 354136<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=354136&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=354136&view=rev</a><br>
> Log:<br>
> Exteded test of .<br>
Were last few commits were meant to be committed?<br>
Regardless, the commit messages could use at lot more work.<br>
<br>
> Modified:<br>
>     cfe/trunk/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp<br>
><br>
> Modified: cfe/trunk/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp?rev=354136&r1=354135&r2=354136&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp?rev=354136&r1=354135&r2=354136&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp (original)<br>
> +++ cfe/trunk/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp Fri Feb 15 06:43:10 2019<br>
> @@ -540,23 +540,27 @@ TEST(MatcherCXXMemberCallExpr, OnImplici<br>
>  }<br>
><br>
>  TEST(Matcher, HasObjectExpr) {<br>
> -  auto M = memberExpr(hasObjectExpression(hasType(cxxRecordDecl(hasName("X")))));<br>
> -  EXPECT_TRUE(matches(<br>
> -      R"cc(<br>
> +  auto Snippet1 = R"cc(<br>
>          struct X {<br>
>            int m;<br>
>            int f(X x) { return x.m; }<br>
>          };<br>
> -      )cc",<br>
> -      M));<br>
> -  EXPECT_TRUE(notMatches(<br>
> -      R"cc(<br>
> +      )cc";<br>
> +  auto Snippet2 = R"cc(<br>
>          struct X {<br>
>            int m;<br>
>            int f(X x) { return m; }<br>
>          };<br>
> -      )cc",<br>
> -      M));<br>
> +      )cc";<br>
> +  auto MatchesX =<br>
> +      memberExpr(hasObjectExpression(hasType(cxxRecordDecl(hasName("X")))));<br>
> +  EXPECT_TRUE(matches(Snippet1, MatchesX));<br>
> +  EXPECT_TRUE(notMatches(Snippet2, MatchesX));<br>
> +<br>
> +  auto MatchesXPointer = memberExpr(<br>
> +      hasObjectExpression(hasType(pointsTo(cxxRecordDecl(hasName("X"))))));<br>
> +  EXPECT_TRUE(notMatches(Snippet1, MatchesXPointer));<br>
> +  EXPECT_TRUE(matches(Snippet2, MatchesXPointer));<br>
>  }<br>
><br>
>  TEST(ForEachArgumentWithParam, ReportsNoFalsePositives) {<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>