<div dir="ltr">When reverting something, can you say why you're reverting in the commit message please?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Feb 15, 2019 at 4:18 AM Sam McCall via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: sammccall<br>
Date: Fri Feb 15 01:18:49 2019<br>
New Revision: 354109<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=354109&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=354109&view=rev</a><br>
Log:<br>
Revert "[Analysis] -Wunreachable-code shouldn't fire on the increment of a foreach loop"<br>
<br>
This reverts commit r354102.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Analysis/ReachableCode.cpp<br>
    cfe/trunk/test/SemaCXX/unreachable-code.cpp<br>
<br>
Modified: cfe/trunk/lib/Analysis/ReachableCode.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/ReachableCode.cpp?rev=354109&r1=354108&r2=354109&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/ReachableCode.cpp?rev=354109&r1=354108&r2=354109&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Analysis/ReachableCode.cpp (original)<br>
+++ cfe/trunk/lib/Analysis/ReachableCode.cpp Fri Feb 15 01:18:49 2019<br>
@@ -631,10 +631,6 @@ void DeadCodeScan::reportDeadCode(const<br>
     // a for/for-range loop.  This is the block that contains<br>
     // the increment code.<br>
     if (const Stmt *LoopTarget = B->getLoopTarget()) {<br>
-      // The increment on a foreach statement is not written.<br>
-      if (isa<CXXForRangeStmt>(LoopTarget))<br>
-        return;<br>
-<br>
       SourceLocation Loc = LoopTarget->getBeginLoc();<br>
       SourceRange R1(Loc, Loc), R2;<br>
<br>
<br>
Modified: cfe/trunk/test/SemaCXX/unreachable-code.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/unreachable-code.cpp?rev=354109&r1=354108&r2=354109&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/unreachable-code.cpp?rev=354109&r1=354108&r2=354109&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/SemaCXX/unreachable-code.cpp (original)<br>
+++ cfe/trunk/test/SemaCXX/unreachable-code.cpp Fri Feb 15 01:18:49 2019<br>
@@ -52,11 +52,6 @@ void test3() {<br>
   }<br>
 }<br>
<br>
-void test4() {<br>
-  for (char c : "abc") // no-warning<br>
-    break;<br>
-}<br>
-<br>
 // PR 6130 - Don't warn about bogus unreachable code with throw's and<br>
 // temporary objects.<br>
 class PR6130 {<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>