<div dir="ltr"><div dir="ltr">On Tue, May 8, 2018 at 3:59 AM Eric Fiselier via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: ericwf<br>
Date: Tue May  8 00:56:05 2018<br>
New Revision: 331745<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=331745&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=331745&view=rev</a><br>
Log:<br>
[C++2a] Implement operator<=>: Fix another bug in the code gen tests.<br>
<br>
Sorry for the failures. I'm quite new at writing code gen tests, and<br>
I'm not sure the best way to make them portable.<br>
<br>
Modified:<br>
    cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp<br>
<br>
Modified: cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp?rev=331745&r1=331744&r2=331745&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp?rev=331745&r1=331744&r2=331745&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp (original)<br>
+++ cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp Tue May  8 00:56:05 2018<br>
@@ -79,7 +79,8 @@ auto mem_ptr_test(MemPtrT x, MemPtrT y)<br>
   // CHECK: %cmp.ptr = icmp eq [[TY:i[0-9]+]] %lhs.memptr.ptr, %rhs.memptr.ptr<br>
   // CHECK: %cmp.ptr.null = icmp eq [[TY]] %lhs.memptr.ptr, 0<br>
   // CHECK: %cmp.adj = icmp eq [[TY]] %lhs.memptr.adj, %rhs.memptr.adj<br>
-  // CHECK: %[[OR:.*]] = or i1 %cmp.ptr.null, %cmp.adj<br>
+  // CHECK: %[[OR:.*]] = or i1<br>
+  // CHECK-SAME %cmp.adj<br></blockquote><div><br></div><div>This is missing the ':' and now doesn't check anything.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
   // CHECK: %memptr.eq = and i1 %cmp.ptr, %[[OR]]<br>
   // CHECK: %sel.eq = select i1 %memptr.eq, i8 [[EQ]], i8 [[NE]]<br>
   // CHECK: %__value_ = getelementptr inbounds %[[SE]], %[[SE]]* %[[DEST]]<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div>