<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Hi Hans,</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">I've recommitted the change in r<span>352463.</span></p>
<p style="margin-top:0;margin-bottom:0"><span><br>
</span></p>
<p style="margin-top:0;margin-bottom:0"><span>cheers,</span></p>
<p style="margin-top:0;margin-bottom:0"><span>Sam</span></p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255); font-family:Calibri,Arial,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<p></p>
<p style="font-family:"Times New Roman""><span style="font-family:Calibri,Helvetica,sans-serif">Sam Parker</span></p>
<span style="font-family:Calibri,Helvetica,sans-serif"></span>
<p style="font-family:"Times New Roman""><span style="font-family:Calibri,Helvetica,sans-serif">Compilation Tools Engineer | Arm</span></p>
<span style="font-family:Calibri,Helvetica,sans-serif"></span>
<p style="font-family:"Times New Roman""><span style="font-family:Calibri,Helvetica,sans-serif">. . . . . . . . . . . . . . . . . . . . . . . . . . .</span></p>
<span style="font-family:Calibri,Helvetica,sans-serif"></span>
<p style="font-family:"Times New Roman""><span style="font-family:Calibri,Helvetica,sans-serif">Arm.com</span></p>
<p></p>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Hans Wennborg <hans@chromium.org><br>
<b>Sent:</b> 25 January 2019 18:26:48<br>
<b>To:</b> Sam Parker<br>
<b>Cc:</b> cfe-commits<br>
<b>Subject:</b> Re: r351740 - [AArch64] Use LL for 64-bit intrinsic arguments</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">I see this was reverted later, but please keep me posted on the<br>
resolution as I think we might want to merge this to the 8.0 release<br>
branch as well.<br>
<br>
Thanks,<br>
Hans<br>
<br>
On Mon, Jan 21, 2019 at 3:01 AM Sam Parker via cfe-commits<br>
<cfe-commits@lists.llvm.org> wrote:<br>
><br>
> Author: sam_parker<br>
> Date: Mon Jan 21 03:01:05 2019<br>
> New Revision: 351740<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=351740&view=rev">http://llvm.org/viewvc/llvm-project?rev=351740&view=rev</a><br>
> Log:<br>
> [AArch64] Use LL for 64-bit intrinsic arguments<br>
><br>
> The ACLE states that 64-bit crc32, wsr, rsr and rbit operands are<br>
> uint64_t so we should have the clang builtin match this description<br>
> - which is what we already do for AArch32.<br>
><br>
> Differential Revision: <a href="https://reviews.llvm.org/D56852">https://reviews.llvm.org/D56852</a><br>
><br>
> Modified:<br>
> cfe/trunk/include/clang/Basic/BuiltinsAArch64.def<br>
> cfe/trunk/test/CodeGen/arm64-crc32.c<br>
> cfe/trunk/test/CodeGen/builtins-arm64.c<br>
><br>
> Modified: cfe/trunk/include/clang/Basic/BuiltinsAArch64.def<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/BuiltinsAArch64.def?rev=351740&r1=351739&r2=351740&view=diff">
http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/BuiltinsAArch64.def?rev=351740&r1=351739&r2=351740&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/include/clang/Basic/BuiltinsAArch64.def (original)<br>
> +++ cfe/trunk/include/clang/Basic/BuiltinsAArch64.def Mon Jan 21 03:01:05 2019<br>
> @@ -32,7 +32,7 @@ BUILTIN(__builtin_arm_clrex, "v", "")<br>
><br>
> // Bit manipulation<br>
> BUILTIN(__builtin_arm_rbit, "UiUi", "nc")<br>
> -BUILTIN(__builtin_arm_rbit64, "LUiLUi", "nc")<br>
> +BUILTIN(__builtin_arm_rbit64, "LLUiLLUi", "nc")<br>
><br>
> // HINT<br>
> BUILTIN(__builtin_arm_nop, "v", "")<br>
> @@ -49,8 +49,8 @@ BUILTIN(__builtin_arm_crc32h, "UiUiUs",<br>
> BUILTIN(__builtin_arm_crc32ch, "UiUiUs", "nc")<br>
> BUILTIN(__builtin_arm_crc32w, "UiUiUi", "nc")<br>
> BUILTIN(__builtin_arm_crc32cw, "UiUiUi", "nc")<br>
> -BUILTIN(__builtin_arm_crc32d, "UiUiLUi", "nc")<br>
> -BUILTIN(__builtin_arm_crc32cd, "UiUiLUi", "nc")<br>
> +BUILTIN(__builtin_arm_crc32d, "UiUiLLUi", "nc")<br>
> +BUILTIN(__builtin_arm_crc32cd, "UiUiLLUi", "nc")<br>
><br>
> // Memory barrier<br>
> BUILTIN(__builtin_arm_dmb, "vUi", "nc")<br>
> @@ -62,10 +62,10 @@ BUILTIN(__builtin_arm_prefetch, "vvC*UiU<br>
><br>
> // System Registers<br>
> BUILTIN(__builtin_arm_rsr, "UicC*", "nc")<br>
> -BUILTIN(__builtin_arm_rsr64, "LUicC*", "nc")<br>
> +BUILTIN(__builtin_arm_rsr64, "LLUicC*", "nc")<br>
> BUILTIN(__builtin_arm_rsrp, "v*cC*", "nc")<br>
> BUILTIN(__builtin_arm_wsr, "vcC*Ui", "nc")<br>
> -BUILTIN(__builtin_arm_wsr64, "vcC*LUi", "nc")<br>
> +BUILTIN(__builtin_arm_wsr64, "vcC*LLUi", "nc")<br>
> BUILTIN(__builtin_arm_wsrp, "vcC*vC*", "nc")<br>
><br>
> // MSVC<br>
><br>
> Modified: cfe/trunk/test/CodeGen/arm64-crc32.c<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/arm64-crc32.c?rev=351740&r1=351739&r2=351740&view=diff">
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/arm64-crc32.c?rev=351740&r1=351739&r2=351740&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/test/CodeGen/arm64-crc32.c (original)<br>
> +++ cfe/trunk/test/CodeGen/arm64-crc32.c Mon Jan 21 03:01:05 2019<br>
> @@ -1,54 +1,57 @@<br>
> // REQUIRES: aarch64-registered-target<br>
> // RUN: %clang_cc1 -triple arm64-none-linux-gnu \<br>
> // RUN: -disable-O0-optnone -S -emit-llvm -o - %s | opt -S -mem2reg | FileCheck %s<br>
> +// RUN: %clang_cc1 -triple aarch64-windows \<br>
> +// RUN: -disable-O0-optnone -S -emit-llvm -o - %s | opt -S -mem2reg | FileCheck %s<br>
> +#include <stdint.h><br>
><br>
> -int crc32b(int a, char b)<br>
> +uint32_t crc32b(uint32_t a, uint8_t b)<br>
> {<br>
> return __builtin_arm_crc32b(a,b);<br>
> // CHECK: [[T0:%[0-9]+]] = zext i8 %b to i32<br>
> // CHECK: call i32 @llvm.aarch64.crc32b(i32 %a, i32 [[T0]])<br>
> }<br>
><br>
> -int crc32cb(int a, char b)<br>
> +uint32_t crc32cb(uint32_t a, uint8_t b)<br>
> {<br>
> return __builtin_arm_crc32cb(a,b);<br>
> // CHECK: [[T0:%[0-9]+]] = zext i8 %b to i32<br>
> // CHECK: call i32 @llvm.aarch64.crc32cb(i32 %a, i32 [[T0]])<br>
> }<br>
><br>
> -int crc32h(int a, short b)<br>
> +uint32_t crc32h(uint32_t a, uint16_t b)<br>
> {<br>
> return __builtin_arm_crc32h(a,b);<br>
> // CHECK: [[T0:%[0-9]+]] = zext i16 %b to i32<br>
> // CHECK: call i32 @llvm.aarch64.crc32h(i32 %a, i32 [[T0]])<br>
> }<br>
><br>
> -int crc32ch(int a, short b)<br>
> +uint32_t crc32ch(uint32_t a, uint16_t b)<br>
> {<br>
> return __builtin_arm_crc32ch(a,b);<br>
> // CHECK: [[T0:%[0-9]+]] = zext i16 %b to i32<br>
> // CHECK: call i32 @llvm.aarch64.crc32ch(i32 %a, i32 [[T0]])<br>
> }<br>
><br>
> -int crc32w(int a, int b)<br>
> +uint32_t crc32w(uint32_t a, uint32_t b)<br>
> {<br>
> return __builtin_arm_crc32w(a,b);<br>
> // CHECK: call i32 @llvm.aarch64.crc32w(i32 %a, i32 %b)<br>
> }<br>
><br>
> -int crc32cw(int a, int b)<br>
> +uint32_t crc32cw(uint32_t a, uint32_t b)<br>
> {<br>
> return __builtin_arm_crc32cw(a,b);<br>
> // CHECK: call i32 @llvm.aarch64.crc32cw(i32 %a, i32 %b)<br>
> }<br>
><br>
> -int crc32d(int a, long b)<br>
> +uint32_t crc32d(uint32_t a, uint64_t b)<br>
> {<br>
> return __builtin_arm_crc32d(a,b);<br>
> // CHECK: call i32 @llvm.aarch64.crc32x(i32 %a, i64 %b)<br>
> }<br>
><br>
> -int crc32cd(int a, long b)<br>
> +uint32_t crc32cd(uint32_t a, uint64_t b)<br>
> {<br>
> return __builtin_arm_crc32cd(a,b);<br>
> // CHECK: call i32 @llvm.aarch64.crc32cx(i32 %a, i64 %b)<br>
><br>
> Modified: cfe/trunk/test/CodeGen/builtins-arm64.c<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/builtins-arm64.c?rev=351740&r1=351739&r2=351740&view=diff">
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/builtins-arm64.c?rev=351740&r1=351739&r2=351740&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/test/CodeGen/builtins-arm64.c (original)<br>
> +++ cfe/trunk/test/CodeGen/builtins-arm64.c Mon Jan 21 03:01:05 2019<br>
> @@ -1,4 +1,6 @@<br>
> // RUN: %clang_cc1 -triple arm64-unknown-linux -disable-O0-optnone -emit-llvm -o - %s | opt -S -mem2reg | FileCheck %s<br>
> +// RUN: %clang_cc1 -triple aarch64-windows -disable-O0-optnone -emit-llvm -o - %s | opt -S -mem2reg | FileCheck %s<br>
> +#include <stdint.h><br>
><br>
> void f0(void *a, void *b) {<br>
> __clear_cache(a,b);<br>
> @@ -55,7 +57,7 @@ unsigned rsr() {<br>
> return __builtin_arm_rsr("1:2:3:4:5");<br>
> }<br>
><br>
> -unsigned long rsr64() {<br>
> +uint64_t rsr64() {<br>
> // CHECK: call i64 @llvm.read_register.i64(metadata ![[M0:[0-9]]])<br>
> return __builtin_arm_rsr64("1:2:3:4:5");<br>
> }<br>
> @@ -72,7 +74,7 @@ void wsr(unsigned v) {<br>
> __builtin_arm_wsr("1:2:3:4:5", v);<br>
> }<br>
><br>
> -void wsr64(unsigned long v) {<br>
> +void wsr64(uint64_t v) {<br>
> // CHECK: call void @llvm.write_register.i64(metadata ![[M0:[0-9]]], i64 %v)<br>
> __builtin_arm_wsr64("1:2:3:4:5", v);<br>
> }<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> cfe-commits@lists.llvm.org<br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</div>
</span></font></div>
</body>
</html>