<div dir="auto"><div>+Ilya who understands the test better...</div><div dir="auto"><br></div><div dir="auto">Some are fixed by r351334 with -target, Ilya could you take a look at windows? Otherwise we could use REQUIRES...<br><br><div class="gmail_quote" dir="auto"><div dir="ltr">On Wed, Jan 16, 2019, 15:16 Jeremy Morse <<a href="mailto:jeremy.morse.llvm@gmail.com" target="_blank" rel="noreferrer">jeremy.morse.llvm@gmail.com</a> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div>Hi Sam,</div><div><br></div><div>Unfortunately this trips up a variety of buildbots:</div><div><br></div><div>    <a href="http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/22376" rel="noreferrer noreferrer" target="_blank">http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/22376</a></div><div>    <a href="http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/15053" rel="noreferrer noreferrer" target="_blank">http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/15053</a></div><div>    <a href="http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/22376" rel="noreferrer noreferrer" target="_blank">http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/22376</a></div><div>    <a href="http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/3401" rel="noreferrer noreferrer" target="_blank">http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/3401</a><br></div><div>    <a href="http://lab.llvm.org:8011/builders/lldb-amd64-ninja-netbsd8/builds/18177" rel="noreferrer noreferrer" target="_blank">http://lab.llvm.org:8011/builders/lldb-amd64-ninja-netbsd8/builds/18177</a></div><div>    <a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/22919" rel="noreferrer noreferrer" target="_blank">http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/22919</a></div><div><br></div><div>For the Windows machines at least, I don't believe lit can cope with replicating shell subprocesses and thus the use of $(which...). (I could be wrong there, but it matches up with the error messages).</div><div><br></div><div>"clang-check-mac-libcxx-fixed-compilation-db.cpp" sounds like it's mac-specific, maybe only "REQUIRES: system-darwin" is needed?</div><div><br></div><div>--</div><div>Thanks,</div><div>Jeremy</div><div><br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
</blockquote></div></div></div></div></div></div></div></div>
</blockquote></div></div></div>