<div dir="ltr"><div dir="ltr"><div dir="ltr">As long as check-all passes with LLVM_ENABLE_PIC=OFF I'm happy :-) (Note it's .dylib on macOS and .dll on Windows, and by default setting LLVM_ENABLE_PIC=OFF causes a static library to be created instead on non-win).</div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jan 15, 2019 at 1:16 PM Michał Górny <<a href="mailto:mgorny@gentoo.org">mgorny@gentoo.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, 2019-01-15 at 13:10 -0500, Nico Weber wrote:<br>
> The tests probably shouldn't run when LLVM_ENABLE_PIC=OFF is set, since<br>
> they all fail there (due to lib/libclang.so not existing).<br>
<br>
Hmm, maybe we could make them conditional to the existence<br>
of libclang.so target?  Would that work for you?<br>
<br>
> <br>
> On Thu, Oct 11, 2018 at 7:59 AM Michal Gorny via cfe-commits <<br>
> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br>
> <br>
> > Author: mgorny<br>
> > Date: Thu Oct 11 04:58:14 2018<br>
> > New Revision: 344241<br>
> > <br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project?rev=344241&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=344241&view=rev</a><br>
> > Log:<br>
> > [tests] Include Python binding tests in CMake rules<br>
> > <br>
> > Add a new CMake rule check-clang-python to run the Python bindings'<br>
> > test suite, and include it in check-all.<br>
> > <br>
> > Differential Revision: <a href="https://reviews.llvm.org/D52840" rel="noreferrer" target="_blank">https://reviews.llvm.org/D52840</a><br>
> > <br>
> > Added:<br>
> >     cfe/trunk/bindings/python/tests/CMakeLists.txt<br>
> > Modified:<br>
> >     cfe/trunk/CMakeLists.txt<br>
> > <br>
> > Modified: cfe/trunk/CMakeLists.txt<br>
> > URL:<br>
> > <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/CMakeLists.txt?rev=344241&r1=344240&r2=344241&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/CMakeLists.txt?rev=344241&r1=344240&r2=344241&view=diff</a><br>
> > <br>
> > ==============================================================================<br>
> > --- cfe/trunk/CMakeLists.txt (original)<br>
> > +++ cfe/trunk/CMakeLists.txt Thu Oct 11 04:58:14 2018<br>
> > @@ -502,6 +502,7 @@ if( CLANG_INCLUDE_TESTS )<br>
> >        )<br>
> >    endif()<br>
> >    add_subdirectory(utils/perf-training)<br>
> > +  add_subdirectory(bindings/python/tests)<br>
> >  endif()<br>
> > <br>
> >  option(CLANG_INCLUDE_DOCS "Generate build targets for the Clang docs."<br>
> > <br>
> > Added: cfe/trunk/bindings/python/tests/CMakeLists.txt<br>
> > URL:<br>
> > <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/bindings/python/tests/CMakeLists.txt?rev=344241&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/bindings/python/tests/CMakeLists.txt?rev=344241&view=auto</a><br>
> > <br>
> > ==============================================================================<br>
> > --- cfe/trunk/bindings/python/tests/CMakeLists.txt (added)<br>
> > +++ cfe/trunk/bindings/python/tests/CMakeLists.txt Thu Oct 11 04:58:14 2018<br>
> > @@ -0,0 +1,7 @@<br>
> > +# Test target to run Python test suite from main build.<br>
> > +<br>
> > +add_custom_target(check-clang-python<br>
> > +       COMMAND CLANG_LIBRARY_PATH=$<TARGET_FILE_DIR:libclang><br>
> > ${PYTHON_EXECUTABLE} -m unittest discover<br>
> > +       DEPENDS libclang<br>
> > +       WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/..)<br>
> > +add_dependencies(check-all check-clang-python)<br>
> > <br>
> > <br>
> > _______________________________________________<br>
> > cfe-commits mailing list<br>
> > <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> > <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
> > <br>
<br>
-- <br>
Best regards,<br>
Michał Górny<br>
</blockquote></div>