<div dir="ltr"><div dir="ltr">Thanks for the note. 350451 will hopefully help.</div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Jan 4, 2019 at 2:18 PM Galina Kistanova via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr">Hello Nico,<br><br>This commit broke tests on llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast builder:<br><a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/41673" target="_blank">http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/41673</a><br></div><div dir="ltr"><br></div><div dir="ltr">. . .<br>Failing Tests (2):<br>    Clang :: CodeGenCXX/debug-info-class-limited-plugin.test<br>    Clang :: Frontend/plugin-vs-debug-info.cpp<br><br>Please have a look ASAP?<br><br>Thanks<br><br>Galina<br></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jan 3, 2019 at 10:29 AM Nico Weber via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: nico<br>
Date: Thu Jan  3 10:26:06 2019<br>
New Revision: 350340<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=350340&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=350340&view=rev</a><br>
Log:<br>
Validate -add-plugin arguments.<br>
<br>
-plugin already prints an error if the name of an unknown plugin is passed.<br>
-add-plugin used to silently ignore that, now it errors too.<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D56273" rel="noreferrer" target="_blank">https://reviews.llvm.org/D56273</a><br>
<br>
Added:<br>
    cfe/trunk/test/Frontend/plugin-unknown.c<br>
Modified:<br>
    cfe/trunk/lib/Frontend/CompilerInvocation.cpp<br>
<br>
Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/CompilerInvocation.cpp?rev=350340&r1=350339&r2=350340&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/CompilerInvocation.cpp?rev=350340&r1=350339&r2=350340&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Frontend/CompilerInvocation.cpp (original)<br>
+++ cfe/trunk/lib/Frontend/CompilerInvocation.cpp Thu Jan  3 10:26:06 2019<br>
@@ -33,6 +33,7 @@<br>
 #include "clang/Frontend/DependencyOutputOptions.h"<br>
 #include "clang/Frontend/FrontendDiagnostic.h"<br>
 #include "clang/Frontend/FrontendOptions.h"<br>
+#include "clang/Frontend/FrontendPluginRegistry.h"<br>
 #include "clang/Frontend/LangStandard.h"<br>
 #include "clang/Frontend/MigratorOptions.h"<br>
 #include "clang/Frontend/PreprocessorOutputOptions.h"<br>
@@ -1663,7 +1664,20 @@ static InputKind ParseFrontendArgs(Front<br>
     Opts.ProgramAction = frontend::PluginAction;<br>
     Opts.ActionName = A->getValue();<br>
   }<br>
-  Opts.AddPluginActions = Args.getAllArgValues(OPT_add_plugin);<br>
+  for (const std::string &Arg : Args.getAllArgValues(OPT_add_plugin)) {<br>
+    bool Found = false;<br>
+    for (FrontendPluginRegistry::iterator it = FrontendPluginRegistry::begin(),<br>
+                                          ie = FrontendPluginRegistry::end();<br>
+         it != ie; ++it) {<br>
+      if (it->getName() == Arg)<br>
+        Found = true;<br>
+    }<br>
+    if (!Found) {<br>
+      Diags.Report(diag::err_fe_invalid_plugin_name) << Arg;<br>
+      continue;<br>
+    }<br>
+    Opts.AddPluginActions.push_back(Arg);<br>
+  }<br>
   for (const auto *AA : Args.filtered(OPT_plugin_arg))<br>
     Opts.PluginArgs[AA->getValue(0)].emplace_back(AA->getValue(1));<br>
<br>
<br>
Added: cfe/trunk/test/Frontend/plugin-unknown.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Frontend/plugin-unknown.c?rev=350340&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Frontend/plugin-unknown.c?rev=350340&view=auto</a><br>
==============================================================================<br>
--- cfe/trunk/test/Frontend/plugin-unknown.c (added)<br>
+++ cfe/trunk/test/Frontend/plugin-unknown.c Thu Jan  3 10:26:06 2019<br>
@@ -0,0 +1,5 @@<br>
+// RUN: not %clang_cc1 -plugin asdf %s 2>&1 | FileCheck %s<br>
+// RUN: not %clang_cc1 -add-plugin asdf %s 2>&1 | FileCheck --check-prefix=ADD %s<br>
+<br>
+// CHECK: unable to find plugin 'asdf'<br>
+// ADD: unable to find plugin 'asdf'<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>