<div dir="ltr">This fix was submitted because a test was failing without it. :-)</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Nov 8, 2018 at 10:08 PM Roman Lebedev <<a href="mailto:lebedev.ri@gmail.com">lebedev.ri@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Test?<br>
<br>
On Fri, Nov 9, 2018 at 4:34 AM Bill Wendling via cfe-commits<br>
<<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: void<br>
> Date: Thu Nov  8 17:32:30 2018<br>
> New Revision: 346461<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=346461&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=346461&view=rev</a><br>
> Log:<br>
> Ignore implicit things like ConstantExpr.<br>
><br>
> Modified:<br>
>     clang-tools-extra/trunk/clang-tidy/performance/NoexceptMoveConstructorCheck.cpp<br>
><br>
> Modified: clang-tools-extra/trunk/clang-tidy/performance/NoexceptMoveConstructorCheck.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/performance/NoexceptMoveConstructorCheck.cpp?rev=346461&r1=346460&r2=346461&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/performance/NoexceptMoveConstructorCheck.cpp?rev=346461&r1=346460&r2=346461&view=diff</a><br>
> ==============================================================================<br>
> --- clang-tools-extra/trunk/clang-tidy/performance/NoexceptMoveConstructorCheck.cpp (original)<br>
> +++ clang-tools-extra/trunk/clang-tidy/performance/NoexceptMoveConstructorCheck.cpp Thu Nov  8 17:32:30 2018<br>
> @@ -58,7 +58,8 @@ void NoexceptMoveConstructorCheck::check<br>
>      // where expr evaluates to false.<br>
>      if (ProtoType->canThrow() == CT_Can) {<br>
>        Expr *E = ProtoType->getNoexceptExpr();<br>
> -      if (!isa<CXXBoolLiteralExpr>(ProtoType->getNoexceptExpr())) {<br>
> +      E = E->IgnoreImplicit();<br>
> +      if (!isa<CXXBoolLiteralExpr>(E)) {<br>
>          diag(E->getExprLoc(),<br>
>               "noexcept specifier on the move %0 evaluates to 'false'")<br>
>              << MethodType;<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>