<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi Sam,<div class=""><br class=""></div><div class="">On 2 Nov 2018, at 13:31, Sam McCall <<a href="mailto:sammccall@google.com" class="">sammccall@google.com</a>> wrote:<div><blockquote type="cite" class=""><div class=""><div dir="ltr" class="">The move of OSLog.h and FormatString.h to AST doesn't look obviously correct.<div class="">Do these really belong in this layer? I think this patch needs review from someone who knows AST/ better than myself... was there a review?</div></div></div></blockquote><div><br class=""></div>Eli reviewed the change for OSLog.h in <a href="https://reviews.llvm.org/D53514" class="">https://reviews.llvm.org/D53514</a> so that it could be used for the main part of the change. After that it was discovered OSLog depends on the other format helpers so there was still a circular dependency; I decided adding the others was a minor enough change to just go ahead.</div><div><br class=""></div><div>The only alternative I see would be an entirely new library (“MiniAnalysis”?), which seems quite excessive.</div><div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="">(If the do belong here: the namespaces and comments don't seem to have been updated)</div></div></div></blockquote><div><br class=""></div>Good point, I’ll get onto fixing that.</div><div><br class=""></div><div>Cheers.</div><div><br class=""></div><div>Tim.</div></div></body></html>