<div dir="ltr">Test removed in r342693.</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Sep 20, 2018 at 3:30 PM Jorge Gorbe Moya <<a href="mailto:jgorbe@google.com">jgorbe@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Zach and I were able to find the cause.<div><br></div><div>Clang on Windows manages to find "file.h" when you #include "/file.h" and that makes the expected diagnostic not appear. MSVC inteprets an #include with a leading slash as an absolute path so I think we have accidentally hit a different bug in Clang :)<div><br></div><div>One option to fix the test would be replacing the slash with another random non-alphanumeric character that can't be interpreted as a directory separator, but at that point I think we can just delete the failing test and rely on the existing include-likely-typo.c that tests with both leading and trailing non-alphanumeric characters.</div><div><br></div><div>The other test in r342668 works because it includes a file that doesn't exist even if you interpret the path as relative so it should be OK to keep while the bug is found.</div><div><br>I'll go find a bug about the behavior on windows. Thanks!</div><div><br></div><div>Jorge<br><br><div class="gmail_quote"><div dir="ltr">On Thu, Sep 20, 2018 at 2:51 PM Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">FWIW we're trying to reproduce here real fast and then will revert or fix real fast.<div><br></div><div>Thanks!</div></div><div dir="ltr"><div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Sep 20, 2018 at 2:46 PM Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Adding Jorge...<br><br><div class="gmail_quote"></div></div><div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Thu, Sep 20, 2018 at 2:36 PM <<a href="mailto:douglas.yung@sony.com" target="_blank">douglas.yung@sony.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Eric,<br>
<br>
The test that you added in this commit is failing on the PS4 Windows bot. Can you please take a look?<br>
<br>
<a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/20052" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/20052</a><br>
<br>
FAIL: Clang :: Preprocessor/include-leading-nonalpha-suggest.c (10765 of 43992)<br>
******************** TEST 'Clang :: Preprocessor/include-leading-nonalpha-suggest.c' FAILED ********************<br>
Script:<br>
--<br>
: 'RUN: at line 1';   c:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.obj\bin\clang.EXE -cc1 -internal-isystem c:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.obj\lib\clang\8.0.0\include -nostdsysteminc C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\test\Preprocessor\include-leading-nonalpha-suggest.c -verify<br>
--<br>
Exit Code: 1<br>
<br>
Command Output (stdout):<br>
--<br>
$ ":" "RUN: at line 1"<br>
$ "c:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.obj\bin\clang.EXE" "-cc1" "-internal-isystem" "c:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.obj\lib\clang\8.0.0\include" "-nostdsysteminc" "C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\test\Preprocessor\include-leading-nonalpha-suggest.c" "-verify"<br>
# command stderr:<br>
error: 'error' diagnostics expected but not seen: <br>
<br>
  File C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\test\Preprocessor\include-leading-nonalpha-suggest.c Line 3: '/empty_file_to_include.h' file not found, did you mean 'empty_file_to_include.h'?<br>
<br>
1 error generated.<br>
<br>
<br>
error: command failed with exit status: 1<br>
<br></blockquote><div><br></div></div></div><div dir="ltr"><div class="gmail_quote"><div>Oof. Thanks. If I don't have something in 10 minutes I'll just revert.</div><div><br></div><div>Thanks!</div></div></div><div dir="ltr"><div class="gmail_quote"><div><br></div><div>-eric</div></div></div><div dir="ltr"><div class="gmail_quote"><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Douglas Yung<br>
<br>
> -----Original Message-----<br>
> From: cfe-commits [mailto:<a href="mailto:cfe-commits-bounces@lists.llvm.org" target="_blank">cfe-commits-bounces@lists.llvm.org</a>] On Behalf<br>
> Of Eric Christopher via cfe-commits<br>
> Sent: Thursday, September 20, 2018 10:23<br>
> To: <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> Subject: r342668 - Add testcases for r342667.<br>
> <br>
> Author: echristo<br>
> Date: Thu Sep 20 10:22:43 2018<br>
> New Revision: 342668<br>
> <br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=342668&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=342668&view=rev</a><br>
> Log:<br>
> Add testcases for r342667.<br>
> <br>
> Added:<br>
>     cfe/trunk/test/Preprocessor/include-leading-nonalpha-no-suggest.c<br>
>     cfe/trunk/test/Preprocessor/include-leading-nonalpha-suggest.c<br>
> <br>
> Added: cfe/trunk/test/Preprocessor/include-leading-nonalpha-no-<br>
> suggest.c<br>
> URL: <a href="http://llvm.org/viewvc/llvm-" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-</a><br>
> project/cfe/trunk/test/Preprocessor/include-leading-nonalpha-no-<br>
> suggest.c?rev=342668&view=auto<br>
> =======================================================================<br>
> =======<br>
> --- cfe/trunk/test/Preprocessor/include-leading-nonalpha-no-suggest.c<br>
> (added)<br>
> +++ cfe/trunk/test/Preprocessor/include-leading-nonalpha-no-suggest.c<br>
> Thu Sep 20 10:22:43 2018<br>
> @@ -0,0 +1,3 @@<br>
> +// RUN: %clang_cc1 %s -verify<br>
> +<br>
> +#include "/non_existing_file_to_include.h" // expected-error<br>
> {{'/non_existing_file_to_include.h' file not found}}<br>
> <br>
> Added: cfe/trunk/test/Preprocessor/include-leading-nonalpha-suggest.c<br>
> URL: <a href="http://llvm.org/viewvc/llvm-" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-</a><br>
> project/cfe/trunk/test/Preprocessor/include-leading-nonalpha-<br>
> suggest.c?rev=342668&view=auto<br>
> =======================================================================<br>
> =======<br>
> --- cfe/trunk/test/Preprocessor/include-leading-nonalpha-suggest.c<br>
> (added)<br>
> +++ cfe/trunk/test/Preprocessor/include-leading-nonalpha-suggest.c Thu<br>
> Sep 20 10:22:43 2018<br>
> @@ -0,0 +1,3 @@<br>
> +// RUN: %clang_cc1 %s -verify<br>
> +<br>
> +#include "/empty_file_to_include.h" // expected-error<br>
> {{'/empty_file_to_include.h' file not found, did you mean<br>
> 'empty_file_to_include.h'?}}<br>
> <br>
> <br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div></blockquote></div>
</blockquote></div></div></div></div>
</blockquote></div>