<div dir="ltr"><span style="color:rgb(0,0,0);font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px">r342510 by dblaikie fixed this.</span><br><div><span style="color:rgb(0,0,0);font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px"><br></span></div><div><span style="color:rgb(0,0,0);font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px">Thanks,</span></div><div><span style="color:rgb(0,0,0);font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px">Steve</span></div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Sep 18, 2018 at 1:18 PM Stephen Hines <<a href="mailto:srhines@google.com">srhines@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Sure, I'm looking now.<div><br></div><div>Thanks,</div><div>Steve</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Sep 18, 2018 at 1:02 PM <<a href="mailto:douglas.yung@sony.com" target="_blank">douglas.yung@sony.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Stephen,<br>
<br>
Your change is causing a test failure on the PS4 linux bot, can you please take a look?<br>
<br>
<a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/36712/steps/test/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/36712/steps/test/logs/stdio</a><br>
<br>
FAIL: Clang :: Driver/clang_f_opts.c (8141 of 44013)<br>
******************** TEST 'Clang :: Driver/clang_f_opts.c' FAILED ********************<br>
...<br>
Command Output (stderr):<br>
--<br>
/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang/test/Driver/clang_f_opts.c:537:29: error: CHECK-NO-MIX-OMIT-FP-PG: expected string not found in input<br>
// CHECK-NO-MIX-OMIT-FP-PG: '-fomit-frame-pointer' not allowed with '-pg'<br>
^<br>
<stdin>:1:1: note: scanning from here<br>
clang version 8.0.0 (trunk 342502)<br>
^<br>
<stdin>:5:934: note: possible intended match here<br>
"/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/bin/clang-8" "-cc1" "-triple" "x86_64-scei-ps4" "-S" "-disable-free" "-main-file-name" "clang_f_opts.c" "-mrelocation-model" "pic" "-pic-level" "2" "-mthread-model" "posix" "-masm-verbose" "-mconstructor-aliases" "-munwind-tables" "-target-cpu" "btver2" "-debugger-tuning=sce" "-mllvm" "-generate-arange-section" "-debug-forward-template-params" "-dwarf-explicit-import" "-coverage-notes-file" "/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/tools/clang/test/Driver/clang_f_opts.gcno" "-resource-dir" "/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/lib/clang/8.0.0" "-fdebug-compilation-dir" "/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/tools/clang/test/Driver" "-fstack-size-section" "-ferror-limit" "19" "-fmessage-length" "0" "-pg" "-stack-protector" "2" "-fdeclspec" "-fobjc-runtime=gnustep" "-fdiagnostics-show-option" "-o" "clang_f_opts.s" "-x" "c" "/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang/test/Driver/clang_f_opts.c" "-faddrsig"<br>
^<br>
<br>
Douglas Yung<br>
<br>
> -----Original Message-----<br>
> From: cfe-commits [mailto:<a href="mailto:cfe-commits-bounces@lists.llvm.org" target="_blank">cfe-commits-bounces@lists.llvm.org</a>] On Behalf<br>
> Of Stephen Hines via cfe-commits<br>
> Sent: Tuesday, September 18, 2018 11:35<br>
> To: <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> Subject: r342501 - Fix logic around determining use of frame pointer<br>
> with -pg.<br>
> <br>
> Author: srhines<br>
> Date: Tue Sep 18 11:34:33 2018<br>
> New Revision: 342501<br>
> <br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=342501&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=342501&view=rev</a><br>
> Log:<br>
> Fix logic around determining use of frame pointer with -pg.<br>
> <br>
> Summary:<br>
> As part of r342165, I rewrote the logic to check whether<br>
> -fno-omit-frame-pointer was passed after a -fomit-frame-pointer<br>
> argument. This CL switches that logic to use the consolidated<br>
> shouldUseFramePointer() function. This fixes a potential issue where -<br>
> pg<br>
> gets used with -fomit-frame-pointer on a platform that must always<br>
> retain<br>
> frame pointers.<br>
> <br>
> Reviewers: dblaikie<br>
> <br>
> Reviewed By: dblaikie<br>
> <br>
> Subscribers: cfe-commits<br>
> <br>
> Differential Revision: <a href="https://reviews.llvm.org/D52191" rel="noreferrer" target="_blank">https://reviews.llvm.org/D52191</a><br>
> <br>
> Modified:<br>
> cfe/trunk/lib/Driver/ToolChains/Clang.cpp<br>
> <br>
> Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-</a><br>
> project/cfe/trunk/lib/Driver/ToolChains/Clang.cpp?rev=342501&r1=342500&<br>
> r2=342501&view=diff<br>
> =======================================================================<br>
> =======<br>
> --- cfe/trunk/lib/Driver/ToolChains/Clang.cpp (original)<br>
> +++ cfe/trunk/lib/Driver/ToolChains/Clang.cpp Tue Sep 18 11:34:33 2018<br>
> @@ -4956,8 +4956,7 @@ void Clang::ConstructJob(Compilation &C,<br>
> }<br>
> <br>
> if (Arg *A = Args.getLastArg(options::OPT_pg))<br>
> - if (Args.hasFlag(options::OPT_fomit_frame_pointer,<br>
> - options::OPT_fno_omit_frame_pointer,<br>
> /*default=*/false))<br>
> + if (shouldUseFramePointer(Args, Triple))<br>
> D.Diag(diag::err_drv_argument_not_allowed_with) << "-fomit-<br>
> frame-pointer"<br>
> << A-<br>
> >getAsString(Args);<br>
> <br>
> <br>
> <br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>
</blockquote></div>