<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><meta http-equiv="Content-Type" content="text/html; charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Yes I have already make the fix commit. It was an error in the tests. <div class=""><br class=""></div><div class=""><a href="https://github.com/llvm-mirror/clang-tools-extra/commit/77ed1cd838a249d6134de9a6bdbe17ef46ecf946" class="">https://github.com/llvm-mirror/clang-tools-extra/commit/77ed1cd838a249d6134de9a6bdbe17ef46ecf946</a></div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">Now on my Mac it compile and all the tests are ok. </div><div class="">Should I try anything else ?<br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">Il giorno 17 set 2018, alle ore 15:14, Alexander Kornienko via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> ha scritto:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div dir="ltr" class="">It looks like this commit breaks buildbots (e.g. <a href="http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/6711" class="">http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/6711</a>). Could you take a look?</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Mon, Sep 17, 2018 at 2:33 PM Idriss Riouak via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: idrissrio<br class="">
Date: Mon Sep 17 05:29:29 2018<br class="">
New Revision: 342388<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=342388&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=342388&view=rev</a><br class="">
Log:<br class="">
[Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void<br class="">
<br class="">
Summary:<br class="">
Hello, i would like to suggest a fix for one of the checks in clang-tidy.The bug was reported in <a href="https://bugs.llvm.org/show_bug.cgi?id=32575" rel="noreferrer" target="_blank" class="">https://bugs.llvm.org/show_bug.cgi?id=32575</a> where you can find more information.<br class="">
<br class="">
For example:<br class="">
```<br class="">
template <typename T0><br class="">
struct S {<br class="">
template <typename T><br class="">
void g() const {<br class="">
int a;<br class="">
(void)a;<br class="">
}<br class="">
};<br class="">
<br class="">
void f() {<br class="">
S<int>().g<int>();<br class="">
}<br class="">
```<br class="">
<br class="">
<br class="">
this piece of code should not trigger any warning by the check modernize-redundant-void-arg but when we execute the following command<br class="">
<br class="">
<br class="">
```<br class="">
clang_tidy -checks=-*,modernize-redundant-void-arg test.cpp -- -std=c++11<br class="">
```<br class="">
<br class="">
we obtain the following warning:<br class="">
<br class="">
/Users/eco419/Desktop/clang-tidy.project/void-redundand_2/test.cpp:6:6: warning: redundant void argument list in function declaration [modernize-redundant-void-arg]<br class="">
(void)a;<br class="">
^~~~<br class="">
<br class="">
Reviewers: aaron.ballman, hokein, alexfh, JonasToth<br class="">
<br class="">
Reviewed By: aaron.ballman, JonasToth<br class="">
<br class="">
Subscribers: JonasToth, lebedev.ri, cfe-commits<br class="">
<br class="">
Tags: #clang-tools-extra<br class="">
<br class="">
Differential Revision: <a href="https://reviews.llvm.org/D52135" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D52135</a><br class="">
<br class="">
Modified:<br class="">
clang-tools-extra/trunk/clang-tidy/modernize/RedundantVoidArgCheck.cpp<br class="">
clang-tools-extra/trunk/test/clang-tidy/modernize-redundant-void-arg.cpp<br class="">
<br class="">
Modified: clang-tools-extra/trunk/clang-tidy/modernize/RedundantVoidArgCheck.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/modernize/RedundantVoidArgCheck.cpp?rev=342388&r1=342387&r2=342388&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/modernize/RedundantVoidArgCheck.cpp?rev=342388&r1=342387&r2=342388&view=diff</a><br class="">
==============================================================================<br class="">
--- clang-tools-extra/trunk/clang-tidy/modernize/RedundantVoidArgCheck.cpp (original)<br class="">
+++ clang-tools-extra/trunk/clang-tidy/modernize/RedundantVoidArgCheck.cpp Mon Sep 17 05:29:29 2018<br class="">
@@ -49,7 +49,7 @@ void RedundantVoidArgCheck::registerMatc<br class="">
return;<br class="">
<br class="">
Finder->addMatcher(functionDecl(parameterCountIs(0), unless(isImplicit()),<br class="">
- unless(isExternC()))<br class="">
+ unless(isInstantiated()), unless(isExternC()))<br class="">
.bind(FunctionId),<br class="">
this);<br class="">
Finder->addMatcher(typedefNameDecl().bind(TypedefId), this);<br class="">
<br class="">
Modified: clang-tools-extra/trunk/test/clang-tidy/modernize-redundant-void-arg.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/modernize-redundant-void-arg.cpp?rev=342388&r1=342387&r2=342388&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/modernize-redundant-void-arg.cpp?rev=342388&r1=342387&r2=342388&view=diff</a><br class="">
==============================================================================<br class="">
--- clang-tools-extra/trunk/test/clang-tidy/modernize-redundant-void-arg.cpp (original)<br class="">
+++ clang-tools-extra/trunk/test/clang-tidy/modernize-redundant-void-arg.cpp Mon Sep 17 05:29:29 2018<br class="">
@@ -488,3 +488,64 @@ void lambda_expression_with_macro_test()<br class="">
// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: redundant void argument list in lambda expression [modernize-redundant-void-arg]<br class="">
// CHECK-FIXES: []() BODY;<br class="">
}<br class="">
+<br class="">
+struct S_1 {<br class="">
+ void g_1(void) const {<br class="">
+ // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: redundant void argument list in function definition [modernize-redundant-void-arg]<br class="">
+ // CHECK-FIXES: void g_1() const {<br class="">
+ int a;<br class="">
+ (void)a;<br class="">
+ }<br class="">
+<br class="">
+ void g_2() const {<br class="">
+ int a;<br class="">
+ (void)a;<br class="">
+ }<br class="">
+};<br class="">
+<br class="">
+template <typename T0><br class="">
+struct S_2 {<br class="">
+ void g_1(void) const {<br class="">
+ // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: redundant void argument list in function definition [modernize-redundant-void-arg]<br class="">
+ // CHECK-FIXES: void g_1() const {<br class="">
+ int a;<br class="">
+ (void)a;<br class="">
+ }<br class="">
+<br class="">
+ void g_2() const {<br class="">
+ int a;<br class="">
+ (void)a;<br class="">
+ }<br class="">
+};<br class="">
+<br class="">
+template <typename T0><br class="">
+struct S_3 {<br class="">
+ template <typename T1><br class="">
+ void g_1(void) const {<br class="">
+ // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: redundant void argument list in function definition [modernize-redundant-void-arg]<br class="">
+ // CHECK-FIXES: void g_1() const {<br class="">
+ int a;<br class="">
+ (void)a;<br class="">
+ }<br class="">
+ template <typename T2><br class="">
+ void g_2() const {<br class="">
+ int a;<br class="">
+ (void)a;<br class="">
+ }<br class="">
+};<br class="">
+<br class="">
+template <typename T1><br class="">
+void g_3(void) {<br class="">
+ // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: redundant void argument list in function definition [modernize-redundant-void-arg]<br class="">
+ // CHECK-FIXES: void g_3(){<br class="">
+ int a;<br class="">
+ (void)a;<br class="">
+}<br class="">
+<br class="">
+//Template instantiation<br class="">
+void f_testTemplate() {<br class="">
+ S_1();<br class="">
+ S_2<int>();<br class="">
+ S_3<int>();<br class="">
+ g_3<int>();<br class="">
+}<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="">
</blockquote></div>
_______________________________________________<br class="">cfe-commits mailing list<br class=""><a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class=""></div></blockquote></div><br class=""></div></div></body></html>