<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Oh, I see. Thank you very much for fixing it!<div class=""><br class=""></div><div class="">I had concerns about platform dependence, but I’ve seen seen some tests in libcxx which use `if […]` so I thought it should be alright (because there was no REQUIRES there). I can see now, that it is a Darwin test, my bad.</div><div class=""><br class=""></div><div class="">Again, thank you very much for helping and apologies for inconvenience.</div><div class=""><br class=""></div><div class="">Kind regards,</div><div class="">Kirill<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 14 Sep 2018, at 22:53, Reid Kleckner <<a href="mailto:rnk@google.com" class="">rnk@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div dir="ltr" class=""><div class="">That construct does not work on Windows, where we don't use bash. We use the lit internal shell, which doesn't support 'if [ ...]'. I marked it REQUIRES: shell in r342282.</div></div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Wed, Sep 12, 2018 at 2:29 AM Kirill Bobyrev via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: omtcyfz<br class="">
Date: Wed Sep 12 02:27:55 2018<br class="">
New Revision: 342036<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=342036&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=342036&view=rev</a><br class="">
Log:<br class="">
Fix buildbots after r342027<br class="">
<br class="">
Modified:<br class="">
clang-tools-extra/trunk/test/clangd/index-tools.test<br class="">
<br class="">
Modified: clang-tools-extra/trunk/test/clangd/index-tools.test<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clangd/index-tools.test?rev=342036&r1=342035&r2=342036&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clangd/index-tools.test?rev=342036&r1=342035&r2=342036&view=diff</a><br class="">
==============================================================================<br class="">
--- clang-tools-extra/trunk/test/clangd/index-tools.test (original)<br class="">
+++ clang-tools-extra/trunk/test/clangd/index-tools.test Wed Sep 12 02:27:55 2018<br class="">
@@ -1,2 +1,3 @@<br class="">
# RUN: global-symbol-builder %p/Inputs/BenchmarkSource.cpp -- -I%p/Inputs > %t.index<br class="">
-# RUN: %clangd-benchmark-dir/IndexBenchmark %t.index %p/Inputs/requests.log --benchmark_min_time=0.01<br class="">
+# FIXME: By default, benchmarks are excluded from the list of default targets hence not built. Find a way to depend on benchmarks to run the next command.<br class="">
+# RUN: if [ -f %clangd-benchmark-dir/IndexBenchmark ]; then %clangd-benchmark-dir/IndexBenchmark %t.index %p/Inputs/requests.log --benchmark_min_time=0.01 ; fi<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></body></html>