<div dir="ltr"><div dir="ltr">Relanded with a fix attempt at 341654.</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Sep 6, 2018 at 12:31 PM A Bergen via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: sudofortune<br>
Date: Thu Sep  6 09:29:40 2018<br>
New Revision: 341560<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=341560&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=341560&view=rev</a><br>
Log:<br>
Reverting r 341390 because it is causing test failures on GreenDragon.<br>
<br>
<a href="http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental/52810/" rel="noreferrer" target="_blank">http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental/52810/</a><br>
<br>
<br>
Modified:<br>
    cfe/trunk/lib/Driver/ToolChains/MSVC.cpp<br>
    cfe/trunk/test/Driver/msvc-link.c<br>
<br>
Modified: cfe/trunk/lib/Driver/ToolChains/MSVC.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/MSVC.cpp?rev=341560&r1=341559&r2=341560&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/MSVC.cpp?rev=341560&r1=341559&r2=341560&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Driver/ToolChains/MSVC.cpp (original)<br>
+++ cfe/trunk/lib/Driver/ToolChains/MSVC.cpp Thu Sep  6 09:29:40 2018<br>
@@ -355,15 +355,6 @@ void visualstudio::Linker::ConstructJob(<br>
                   options::OPT__SLASH_Zd))<br>
     CmdArgs.push_back("-debug");<br>
<br>
-  // Pass on /Brepro if it was passed to the compiler.<br>
-  // Note that /Brepro maps to -mno-incremental-linker-compatible.<br>
-  bool DefaultIncrementalLinkerCompatible =<br>
-      C.getDefaultToolChain().getTriple().isWindowsMSVCEnvironment();<br>
-  if (!Args.hasFlag(options::OPT_mincremental_linker_compatible,<br>
-                    options::OPT_mno_incremental_linker_compatible,<br>
-                    DefaultIncrementalLinkerCompatible))<br>
-    CmdArgs.push_back("-Brepro");<br>
-<br>
   bool DLL = Args.hasArg(options::OPT__SLASH_LD, options::OPT__SLASH_LDd,<br>
                          options::OPT_shared);<br>
   if (DLL) {<br>
<br>
Modified: cfe/trunk/test/Driver/msvc-link.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/msvc-link.c?rev=341560&r1=341559&r2=341560&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/msvc-link.c?rev=341560&r1=341559&r2=341560&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/Driver/msvc-link.c (original)<br>
+++ cfe/trunk/test/Driver/msvc-link.c Thu Sep  6 09:29:40 2018<br>
@@ -3,7 +3,6 @@<br>
 // BASIC: "-out:a.exe"<br>
 // BASIC: "-defaultlib:libcmt"<br>
 // BASIC: "-nologo"<br>
-// BASIC-NOT: "-Brepro"<br>
<br>
 // RUN: %clang -target i686-pc-windows-msvc -shared -o a.dll -### %s 2>&1 | FileCheck --check-prefix=DLL %s<br>
 // DLL: link.exe"<br>
@@ -17,14 +16,3 @@<br>
 // LIBPATH: "-libpath:/usr/lib"<br>
 // LIBPATH: "-nologo"<br>
<br>
-// RUN: %clang_cl /Brepro -### %s 2>&1 | FileCheck --check-prefix=REPRO %s<br>
-// REPRO: link.exe"<br>
-// REPRO: "-out:msvc-link.exe"<br>
-// REPRO: "-nologo"<br>
-// REPRO: "-Brepro"<br>
-<br>
-// RUN: %clang_cl /Brepro- -### %s 2>&1 | FileCheck --check-prefix=NOREPRO %s<br>
-// NOREPRO: link.exe"<br>
-// NOREPRO: "-out:msvc-link.exe"<br>
-// NOREPRO: "-nologo"<br>
-// NOREPRO-NOT: "-Brepro"<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>