<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Sorry, but my patch is not reverted, and as for now it only reads:</p>
<pre style="font-family: "Courier New", courier, monotype, monospace; color: rgb(0, 0, 0); font-size: medium; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-style: initial; text-decoration-color: initial;"><span class="stdout" style="font-family: "Courier New", courier, monotype, monospace; color: black;">Failing Tests (2):
LLVM :: CodeGen/AMDGPU/mubuf-legalize-operands.ll
LLVM :: CodeGen/AMDGPU/mubuf-legalize-operands.mir
</span></pre>
So I'm considering it was a side-effect of some other test.<br class="Apple-interchange-newline">
<br>
<div class="moz-cite-prefix">On 09/05/2018 10:00 PM, Galina Kistanova wrote:<br>
</div>
<blockquote type="cite" cite="mid:CAJ8eiNwCNk_onAb9b2wQbkTRrdMf1ypB-gd_p9=nGysNJdMt2Q@mail.gmail.com">
<div dir="ltr">
<div dir="ltr">Hello Diogo,<br>
<br>
This commit added couple of broken tests to one of our builders:<br>
<a href="http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win" moz-do-not-send="true">http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win</a><br>
<br>
. . .<br>
Failing Tests (5):<br>
Clang :: Headers/arm-fp16-header.c<br>
Clang :: Headers/arm-neon-header.c<br>
. . .<br>
<br>
Please have a look?<br>
The builder was already red and did not send notifications on this.<br>
<br>
Thanks<br>
<br>
Galina<br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Wed, Sep 5, 2018 at 7:59 AM Diogo N. Sampaio via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" moz-do-not-send="true">cfe-commits@lists.llvm.org</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: dnsampaio<br>
Date: Wed Sep 5 07:56:21 2018<br>
New Revision: 341475<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=341475&view=rev" rel="noreferrer" target="_blank" moz-do-not-send="true">
http://llvm.org/viewvc/llvm-project?rev=341475&view=rev</a><br>
Log:<br>
Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89<br>
<br>
<br>
Summary:<br>
The inline attribute is not valid for C standard 89. Replace the argument in the generation of header files with __inline, as well adding tests for both header files.<br>
<br>
Reviewers: pbarrio, SjoerdMeijer, javed.absar, t.p.northover<br>
<br>
Subscribers: t.p.northover, kristof.beyls, chrib, cfe-commits<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D51683" rel="noreferrer" target="_blank" moz-do-not-send="true">
https://reviews.llvm.org/D51683</a><br>
<br>
test/Headers/arm-fp16-header.c<br>
test/Headers/arm-neon-header.c<br>
utils/TableGen/NeonEmitter.cpp<br>
<br>
Added:<br>
cfe/trunk/test/Headers/arm-fp16-header.c<br>
Modified:<br>
cfe/trunk/test/Headers/arm-neon-header.c<br>
cfe/trunk/utils/TableGen/NeonEmitter.cpp<br>
<br>
Added: cfe/trunk/test/Headers/arm-fp16-header.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Headers/arm-fp16-header.c?rev=341475&view=auto" rel="noreferrer" target="_blank" moz-do-not-send="true">
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Headers/arm-fp16-header.c?rev=341475&view=auto</a><br>
==============================================================================<br>
--- cfe/trunk/test/Headers/arm-fp16-header.c (added)<br>
+++ cfe/trunk/test/Headers/arm-fp16-header.c Wed Sep 5 07:56:21 2018<br>
@@ -0,0 +1,19 @@<br>
+// RUN: %clang -fsyntax-only -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c89 -xc %s<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c99 -xc %s<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c11 -xc %s<br>
+<br>
+// RUN: %clang -fsyntax-only -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c89 -xc %s<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c99 -xc %s<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c11 -xc %s<br>
+<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c++98 -xc++ %s<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c++11 -xc++ %s<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c++14 -xc++ %s<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c++17 -xc++ %s<br>
+<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c++98 -xc++ %s<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c++11 -xc++ %s<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c++14 -xc++ %s<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c++17 -xc++ %s<br>
+<br>
+#include <arm_fp16.h><br>
<br>
Modified: cfe/trunk/test/Headers/arm-neon-header.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Headers/arm-neon-header.c?rev=341475&r1=341474&r2=341475&view=diff" rel="noreferrer" target="_blank" moz-do-not-send="true">
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Headers/arm-neon-header.c?rev=341475&r1=341474&r2=341475&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/Headers/arm-neon-header.c (original)<br>
+++ cfe/trunk/test/Headers/arm-neon-header.c Wed Sep 5 07:56:21 2018<br>
@@ -2,4 +2,23 @@<br>
// RUN: %clang_cc1 -triple thumbv7-apple-darwin10 -target-cpu cortex-a8 -fsyntax-only -fno-lax-vector-conversions -ffreestanding %s<br>
// RUN: %clang_cc1 -x c++ -triple thumbv7-apple-darwin10 -target-cpu cortex-a8 -fsyntax-only -Wvector-conversions -ffreestanding %s<br>
<br>
+// RUN: %clang -fsyntax-only -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c89 -xc %s<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c99 -xc %s<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c11 -xc %s<br>
+<br>
+// RUN: %clang -fsyntax-only -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c89 -xc %s<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c99 -xc %s<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c11 -xc %s<br>
+<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c++98 -xc++ %s<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c++11 -xc++ %s<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c++14 -xc++ %s<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c++17 -xc++ %s<br>
+<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c++98 -xc++ %s<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c++11 -xc++ %s<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c++14 -xc++ %s<br>
+// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c++17 -xc++ %s<br>
+<br>
#include <arm_neon.h><br>
+<br>
<br>
Modified: cfe/trunk/utils/TableGen/NeonEmitter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/utils/TableGen/NeonEmitter.cpp?rev=341475&r1=341474&r2=341475&view=diff" rel="noreferrer" target="_blank" moz-do-not-send="true">
http://llvm.org/viewvc/llvm-project/cfe/trunk/utils/TableGen/NeonEmitter.cpp?rev=341475&r1=341474&r2=341475&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/utils/TableGen/NeonEmitter.cpp (original)<br>
+++ cfe/trunk/utils/TableGen/NeonEmitter.cpp Wed Sep 5 07:56:21 2018<br>
@@ -2409,7 +2409,7 @@ void NeonEmitter::run(raw_ostream &OS) {<br>
OS << "#endif\n";<br>
OS << "\n";<br>
<br>
- OS << "#define __ai static inline __attribute__((__always_inline__, "<br>
+ OS << "#define __ai static __inline __attribute__((__always_inline__, "<br>
"__nodebug__))\n\n";<br>
<br>
SmallVector<Intrinsic *, 128> Defs;<br>
@@ -2518,7 +2518,7 @@ void NeonEmitter::runFP16(raw_ostream &O<br>
<br>
OS << "typedef __fp16 float16_t;\n";<br>
<br>
- OS << "#define __ai static inline __attribute__((__always_inline__, "<br>
+ OS << "#define __ai static __inline __attribute__((__always_inline__, "<br>
"__nodebug__))\n\n";<br>
<br>
SmallVector<Intrinsic *, 128> Defs;<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" moz-do-not-send="true">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" moz-do-not-send="true">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote>
</div>
</blockquote>
<br>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose,
or store or copy the information in any medium. Thank you.
</body>
</html>