<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Thu, 9 Aug 2018 at 14:14, Erich Keane via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: erichkeane<br>
Date: Thu Aug  9 14:13:46 2018<br>
New Revision: 339387<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=339387&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=339387&view=rev</a><br>
Log:<br>
Revert -r339382, which apparently breaks the Windows build.<br>
<br>
Modified:<br>
    cfe/trunk/include/clang/Sema/ParsedAttr.h<br>
<br>
Modified: cfe/trunk/include/clang/Sema/ParsedAttr.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/ParsedAttr.h?rev=339387&r1=339386&r2=339387&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/ParsedAttr.h?rev=339387&r1=339386&r2=339387&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Sema/ParsedAttr.h (original)<br>
+++ cfe/trunk/include/clang/Sema/ParsedAttr.h Thu Aug  9 14:13:46 2018<br>
@@ -118,7 +118,9 @@ class ParsedAttr final<br>
     : private llvm::TrailingObjects<<br>
           ParsedAttr, ArgsUnion, detail::AvailabilityData,<br>
           detail::TypeTagForDatatypeData, ParsedType, detail::PropertyData> {<br>
-  friend class TrailingObjects;<br>
+  friend class llvm::TrailingObjects<<br>
+      ParsedAttr, ArgsUnion, detail::AvailabilityData,<br>
+      detail::TypeTagForDatatypeData, ParsedType, detail::PropertyData>;<br></blockquote><div><br></div><div>You need to use "friend TrailingObjects;" here, not "friend class TrailingObjects;", to avoid breaking MSVC (which doesn't implement injected-class-names quite according to spec).</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
   size_t numTrailingObjects(OverloadToken<ArgsUnion>) const { return NumArgs; }<br>
   size_t numTrailingObjects(OverloadToken<detail::AvailabilityData>) const {<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div>