<div dir="ltr">Hi Jeremy,<div><br></div><div>Thank you for reporting the issue and apologies for inconvenience. There was another bug which caused buildbots crashes, I was looking into that before so I missed this one.</div><div><br></div><div>I built Clang 3.6 and Clang 3.7 locally, simply wrapping everything into std::move didn't resolve the issue, I reverted the changes (<a href="https://reviews.llvm.org/rL338054">https://reviews.llvm.org/rL338054</a>) and will investigate.</div><div><br></div><div>Thank you for reaching out,</div><div>Kirill Bobyrev</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jul 26, 2018 at 7:16 PM Jeremy Morse <<a href="mailto:jeremy.morse.llvm@gmail.com">jeremy.morse.llvm@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">

<div style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial"><span style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">[Resending with cfe-commits@, whoops]</span></div><div style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial"><span style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><br></span></div><div style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial"><span style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Hi Kirill,</span></div><span style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><div><span style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><br></span></div><div><span style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><span style="font-size:small;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">We believe this </span>patch might be breaking one of the buildbots:<br></span></div><div><span style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><br></span></div><div><span style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">   <span> </span><a href="http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test/builds/29719" style="color:rgb(17,85,204)" target="_blank">http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test/builds/29719</a></span></div><div><span style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><br></span></div><div><span style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Which is complaining about the std::unique_ptr copy constructor being called in <span style="background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">DexIndexTests.cpp. It seems likely that returning a unique_ptr:</span></span></div><div><span style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><br></span></div>> std::unique_ptr<Iterator></span><span class="m_-6798083264252060510gmail-im" style="color:rgb(80,0,80);font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial"><br style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial"><span style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">> createAnd(std::vector<std::</span><span style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">unique_ptr<Iterator>> Children) {</span><br style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial"></span><span class="m_-6798083264252060510gmail-im" style="color:rgb(80,0,80);font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial"><span style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">>   return llvm::make_unique<AndIterator></span><span style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">(move(Children));</span><br style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial"><span style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">> }</span><div><span style="font-size:12.8px"><br></span></div></span><div style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial"><span style="font-size:12.8px">And sites such as:</span></div><div style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial"><span style="font-size:12.8px"><br></span></div><div style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial"><span class="m_-6798083264252060510gmail-im" style="color:rgb(80,0,80)"><span style="font-size:12.8px"><span style="background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">>  auto AndEmpty = createAnd({create(L0)});</span><br style="background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"></span><div><span style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><br></span></div></span><div>Are triggering a bug in clang 3.7 and 3.8 where the move constructor isn't correctly inferred:</div><div><br></div><div>    <a href="https://godbolt.org/g/Aquug4" style="color:rgb(17,85,204)" target="_blank">https://godbolt.org/g/Aquug4</a></div><div><br></div><div>Wrapping everything in std::move will likely fix that, those two versions of clang are still officially supported by LLVM/Clang.</div></div><div style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial"><br></div><div style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial">--</div><div style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial">Thanks,</div><div style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial">Jeremy</div><div class="m_-6798083264252060510gmail-yj6qo" style="font-size:12.8px;text-decoration-style:initial;text-decoration-color:initial"></div><div class="gmail_extra"><br></div></div>
</blockquote></div></div>