<div dir="ltr">Thank you for the clarification. <br></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jul 25, 2018 at 9:16 PM James Y Knight <<a href="mailto:jyknight@google.com">jyknight@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">As is the case on most modern platforms, the ability to store a high-res file timestamp is dependent on the filesystem the file is stored on.<div><br></div><div><div>The HFS+ filesystem (used by default before macOS 10.13) stores timestamps at a 1-second granularity, and APFS (now the default) at a 1 nanosecond granularity.</div><div><br></div><div>1-second granularity is also the norm on many of the supported filesystems on Linux as well.</div><div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jul 25, 2018 at 10:43 PM Eric Fiselier via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Looks like macOS 10.11 only supports a resolution of seconds, but I can't find documentation confirming that.<div><br></div><div>I'll adjust the test.<div><br></div><div>/Eric</div></div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jul 25, 2018 at 8:33 PM Alex L <<a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Looks like '<span style="font-size:12.800000190734863px">SupportsNanosecondRoundTrip' is set to 0.</span></div><div class="gmail_extra"><br><div class="gmail_quote">On 25 July 2018 at 19:30, Alex L <span dir="ltr"><<a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Sure,<div><br></div><div><p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">Standard Error:</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">--</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">PRIOR:3</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">AFTER:0</span></p><p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"><br></span></p><p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">Diff:</span></p><p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"><br></span></p><p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(180,36,25)"><span style="font-variant-ligatures:no-common-ligatures">- return last_write_time(p) == ft;</span></p><p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(47,180,29)"><span style="font-variant-ligatures:no-common-ligatures">+ std::cerr << "PRIOR:" << (long long)ft.time_since_epoch().count() << std::endl;</span></p><p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(47,180,29)"><span style="font-variant-ligatures:no-common-ligatures">+ auto ft2 = last_write_time(p);</span></p><p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(47,180,29)"><span style="font-variant-ligatures:no-common-ligatures">+ std::cerr << "AFTER:" << (long long)ft2.time_since_epoch().count() << std::endl;</span></p><p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">
</span></p><p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(47,180,29)"><span style="font-variant-ligatures:no-common-ligatures">+ return ft2 == ft;</span></p></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 25 July 2018 at 19:20, Eric Fiselier <span dir="ltr"><<a href="mailto:eric@efcs.ca" target="_blank">eric@efcs.ca</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Could you tell me what the value of the initial time point, and the resulting one are on this line?<div><br></div><div><a href="https://github.com/llvm-mirror/libcxx/blob/master/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp#L224" target="_blank">https://github.com/llvm-mirror/libcxx/blob/master/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp#L224</a></div></div><br><div class="gmail_quote"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108h5"><div dir="ltr">On Wed, Jul 25, 2018 at 8:17 PM Alex L <<a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>> wrote:<br></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108h5"><div dir="ltr">Please let me know if this information is helpful. If not, I'll mark the test as UNSUPPORTED for darwin for the time being and will create an internal issue to track the investigation into the OS-specific failure.<div>Cheers,</div><div>Alex</div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108h5">On 25 July 2018 at 19:12, Alex L <span dir="ltr"><<a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108h5"><div dir="ltr">I got the following output on an macOS10.11 machine:<div><br></div><div><p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">Exit Code: 1</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">Standard Error:</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">--</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">Test Case = file, epoch_time</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">0</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">0</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">Test Case = dir, epoch_time</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">0</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">0</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">Test Case = file, future_time</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">In set_last_write_time_dynamic_env_test():455 Assertion TEST_CHECK(CompareTime(got_time, TC.new_time)) failed.</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> in file: /Users/local/llvm/projects/libcxx/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0);min-height:13px"><span style="font-variant-ligatures:no-common-ligatures"> </span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">1532581924000000000</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">1532581924695307000</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">Test Case = dir, future_time</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">In set_last_write_time_dynamic_env_test():455 Assertion TEST_CHECK(CompareTime(got_time, TC.new_time)) failed.</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> in file: /Users/local/llvm/projects/libcxx/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0);min-height:13px"><span style="font-variant-ligatures:no-common-ligatures"> </span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">1532581924000000000</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">1532581924695307000</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">Test Case = file, past_time</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">In set_last_write_time_dynamic_env_test():455 Assertion TEST_CHECK(CompareTime(got_time, TC.new_time)) failed.</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> in file: /Users/local/llvm/projects/libcxx/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0);min-height:13px"><span style="font-variant-ligatures:no-common-ligatures"> </span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">1532570860000000000</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">1532570860695273000</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">Test Case = dir, past_time</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">In set_last_write_time_dynamic_env_test():455 Assertion TEST_CHECK(CompareTime(got_time, TC.new_time)) failed.</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> in file: /Users/local/llvm/projects/libcxx/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0);min-height:13px"><span style="font-variant-ligatures:no-common-ligatures"> </span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">1532570860000000000</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">1532570860695273000</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">Test Case = file, before_epoch_time</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">In set_last_write_time_dynamic_env_test():455 Assertion TEST_CHECK(CompareTime(got_time, TC.new_time)) failed.</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> in file: /Users/local/llvm/projects/libcxx/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0);min-height:13px"><span style="font-variant-ligatures:no-common-ligatures"> </span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">-223000000000</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">-222000017000</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">Test Case = dir, before_epoch_time</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">In set_last_write_time_dynamic_env_test():455 Assertion TEST_CHECK(CompareTime(got_time, TC.new_time)) failed.</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> in file: /Users/local/llvm/projects/libcxx/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0);min-height:13px"><span style="font-variant-ligatures:no-common-ligatures"> </span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">-223000000000</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">-222000017000</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">Test Case = file, just_before_epoch_time</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">In set_last_write_time_dynamic_env_test():455 Assertion TEST_CHECK(CompareTime(got_time, TC.new_time)) failed.</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> in file: /Users/local/llvm/projects/libcxx/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0);min-height:13px"><span style="font-variant-ligatures:no-common-ligatures"> </span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">-1000000000</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">-17000</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">Test Case = dir, just_before_epoch_time</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">In set_last_write_time_dynamic_env_test():455 Assertion TEST_CHECK(CompareTime(got_time, TC.new_time)) failed.</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> in file: /Users/local/llvm/projects/libcxx/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0);min-height:13px"><span style="font-variant-ligatures:no-common-ligatures"> </span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">-1000000000</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">-17000</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">In last_write_time_symlink_test():487 Assertion TEST_CHECK(got_time == new_time) failed.</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> in file: /Users/local/llvm/projects/libcxx/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0);min-height:13px"><span style="font-variant-ligatures:no-common-ligatures"> </span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">In last_write_time_symlink_test():489 Assertion TEST_CHECK(CompareTime(LastWriteTime(file), new_time)) failed.</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> in file: /Users/local/llvm/projects/libcxx/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0);min-height:13px"><span style="font-variant-ligatures:no-common-ligatures"> </span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">Summary for testsuite last_write_time_test_suite:</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> 7 of 9 test cases passed.</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> 88 of 98 assertions passed.</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> 0 unsupported test cases.</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">--</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0);min-height:13px"><span style="font-variant-ligatures:no-common-ligatures"></span><br></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">Compiled test failed unexpectedly!</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">********************</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">Testing Time: 4.43s</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">********************</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">Failing Tests (1):</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> libc++ :: std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0);min-height:13px"><span style="font-variant-ligatures:no-common-ligatures"></span><br></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> Unexpected Failures: 1</span></p></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108h5">On 25 July 2018 at 18:20, Eric Fiselier <span dir="ltr"><<a href="mailto:eric@efcs.ca" target="_blank">eric@efcs.ca</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108h5"><div dir="ltr">OK. I also added debug print statements to the test to give more information. I'm just waiting for the bots to cycle now.</div><br></div></div><div class="gmail_quote"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108h5"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108m_6049084517487907175m_-944508710234176516m_-2737215435106245606h5"><div dir="ltr">On Wed, Jul 25, 2018 at 7:18 PM Alex L <<a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>> wrote:<br></div></div></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108h5"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108m_6049084517487907175m_-944508710234176516m_-2737215435106245606h5"><div dir="ltr">I couldn't reproduce it on my machine, and I don't have access to the bot ATM, but I will try it on an older OS to see if it's an issue with the particular OS that's used on our bot.<div><br></div><div>Cheers,</div><div>Alex</div></div></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108h5"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108m_6049084517487907175m_-944508710234176516m_-2737215435106245606h5">On 25 July 2018 at 17:43, Alex L <span dir="ltr"><<a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>></span> wrote:<br></div></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108h5"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108m_6049084517487907175m_-944508710234176516m_-2737215435106245606h5"><div dir="ltr">I'll take a look and will try to reproduce it right now.</div></div></div></div></div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108m_6049084517487907175m_-944508710234176516m_-2737215435106245606m_8659656676178802563m_6747764441411225383HOEnZb"><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108m_6049084517487907175m_-944508710234176516m_-2737215435106245606m_8659656676178802563m_6747764441411225383h5"><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108h5"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108m_6049084517487907175m_-944508710234176516m_-2737215435106245606h5">On 25 July 2018 at 17:37, Eric Fiselier <span dir="ltr"><<a href="mailto:eric@efcs.ca" target="_blank">eric@efcs.ca</a>></span> wrote:<br></div></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><br><div class="gmail_quote"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108h5"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108m_6049084517487907175m_-944508710234176516m_-2737215435106245606h5"><span><div dir="ltr">On Wed, Jul 25, 2018 at 6:03 PM Alex L <<a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hmm, looks like the added test is failing on Darwin even after your fixes.<div><br></div><div>Do you have an idea of why that could be?</div></div></blockquote><div> </div></span><div>Not yet, working on it now.</div><div>I'm failing to reproduce it on my macbook though. If you can, any information about what's going on would be helpful.</div><div>Like what are those actual values?</div></div></div></div></div><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108m_6049084517487907175m_-944508710234176516m_-2737215435106245606m_8659656676178802563m_6747764441411225383m_-5557678886675019082h5"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108h5"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108m_6049084517487907175m_-944508710234176516m_-2737215435106245606h5"><div dir="ltr"><div><br></div><div><a href="http://lab.llvm.org:8080/green/job/libcxx_master_cmake/4784/testReport/junit/libc++/std_experimental_filesystem_fs_op_funcs_fs_op_last_write_time/last_write_time_pass_cpp/" target="_blank">http://lab.llvm.org:8080/green/job/libcxx_master_cmake/4784/testReport/junit/libc++/std_experimental_filesystem_fs_op_funcs_fs_op_last_write_time/last_write_time_pass_cpp/</a><br></div><div><br></div><div><div>Compiled With: ['/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++', '-o', '/Users/buildslave/jenkins/sharedspace/libcxx/build/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/Output/last_write_time.pass.cpp.o', '-x', 'c++', '/Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp', '-c', '-v', '-arch', 'x86_64', '-mmacosx-version-min=10.13', '-D_LIBCPP_DISABLE_AVAILABILITY', '-ftemplate-depth=270', '-Werror=thread-safety', '-std=c++11', '-include', '/Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/test/support/nasty_macros.hpp', '-nostdinc++', '-I/Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/include', '-I/Users/buildslave/jenkins/sharedspace/libcxx/build/include/c++build', '-isysroot', '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk', '-I/Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/test/support', '-DLIBCXX_FILESYSTEM_STATIC_TEST_ROOT="/Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/test/std/experimental/filesystem/Inputs/static_test_env"', '-DLIBCXX_FILESYSTEM_DYNAMIC_TEST_ROOT="/Users/buildslave/jenkins/sharedspace/libcxx/build/test/filesystem/Output/dynamic_env"', '-DLIBCXX_FILESYSTEM_DYNAMIC_TEST_HELPER="/usr/local/opt/python@2/bin/python2.7 /Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/test/support/filesystem_dynamic_test_helper.py"', '-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER', '-Wall', '-Wextra', '-Werror', '-Wuser-defined-warnings', '-Wshadow', '-Wno-unused-command-line-argument', '-Wno-attributes', '-Wno-pessimizing-move', '-Wno-c++11-extensions', '-Wno-user-defined-literals', '-Wno-noexcept-type', '-Wno-aligned-allocation-unavailable', '-Wsign-compare', '-Wunused-variable', '-Wunused-parameter', '-Wunreachable-code', '-Wno-conversion', '-Wno-unused-local-typedef', '-c', '&&', '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++', '-o', '/Users/buildslave/jenkins/sharedspace/libcxx/build/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/Output/last_write_time.pass.cpp.exe', '/Users/buildslave/jenkins/sharedspace/libcxx/build/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/Output/last_write_time.pass.cpp.o', '-v', '-arch', 'x86_64', '-mmacosx-version-min=10.13', '-D_LIBCPP_DISABLE_AVAILABILITY', '-ftemplate-depth=270', '-L/Users/buildslave/jenkins/sharedspace/libcxx/build/lib', '-Wl,-rpath,/Users/buildslave/jenkins/sharedspace/libcxx/build/lib', '-nodefaultlibs', '-lc++experimental', '-lc++', '-lSystem']</div><div>Command: ['/Users/buildslave/jenkins/sharedspace/libcxx/build/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/Output/last_write_time.pass.cpp.exe']</div><div>Exit Code: 1</div><div>Standard Error:</div><div>--</div><div>In set_last_write_time_dynamic_env_test():451 Assertion TEST_CHECK(CompareTime(got_time, TC.new_time)) failed.</div><div> in file: /Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</div><div> </div><div>In set_last_write_time_dynamic_env_test():451 Assertion TEST_CHECK(CompareTime(got_time, TC.new_time)) failed.</div><div> in file: /Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</div><div> </div><div>In set_last_write_time_dynamic_env_test():451 Assertion TEST_CHECK(CompareTime(got_time, TC.new_time)) failed.</div><div> in file: /Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</div><div> </div><div>In set_last_write_time_dynamic_env_test():451 Assertion TEST_CHECK(CompareTime(got_time, TC.new_time)) failed.</div><div> in file: /Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</div><div> </div><div>In set_last_write_time_dynamic_env_test():451 Assertion TEST_CHECK(CompareTime(got_time, TC.new_time)) failed.</div><div> in file: /Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</div><div> </div><div>In set_last_write_time_dynamic_env_test():451 Assertion TEST_CHECK(CompareTime(got_time, TC.new_time)) failed.</div><div> in file: /Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</div><div> </div><div>In set_last_write_time_dynamic_env_test():451 Assertion TEST_CHECK(CompareTime(got_time, TC.new_time)) failed.</div><div> in file: /Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</div><div> </div><div>In set_last_write_time_dynamic_env_test():451 Assertion TEST_CHECK(CompareTime(got_time, TC.new_time)) failed.</div><div> in file: /Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</div><div> </div><div>In last_write_time_symlink_test():477 Assertion TEST_CHECK(got_time == new_time) failed.</div><div> in file: /Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</div><div> </div><div>In last_write_time_symlink_test():479 Assertion TEST_CHECK(CompareTime(LastWriteTime(file), new_time)) failed.</div><div> in file: /Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp</div><div> </div><div>Summary for testsuite last_write_time_test_suite:</div><div> 7 of 9 test cases passed.</div><div> 78 of 88 assertions passed.</div><div> 0 unsupported test cases.</div><div>--</div><div><br></div><div>Compiled test failed unexpectedly!</div></div><div><br></div><div>Thanks,</div><div>Alex</div><div><br></div></div></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108h5"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108m_6049084517487907175m_-944508710234176516m_-2737215435106245606h5">On 25 July 2018 at 17:00, Alex L <span dir="ltr"><<a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>></span> wrote:<br></div></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108h5"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108m_6049084517487907175m_-944508710234176516m_-2737215435106245606h5"><div dir="ltr">Sure! Fixed it up in r337984.</div></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108h5"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108m_6049084517487907175m_-944508710234176516m_-2737215435106245606h5"><span>On 25 July 2018 at 15:03, Eric Fiselier <span dir="ltr"><<a href="mailto:eric@efcs.ca" target="_blank">eric@efcs.ca</a>></span> wrote:<br></span></div></div></div></div><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108m_6049084517487907175m_-944508710234176516m_-2737215435106245606m_8659656676178802563m_6747764441411225383m_-5557678886675019082m_3629139256100849010m_-6285619442336665827m_624462420802478192h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><br><div class="gmail_quote"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108h5"><div><div class="m_-4607788935754296452m_4073015218012181407m_-1437840478281159422m_6121380529775480108m_6049084517487907175m_-944508710234176516m_-2737215435106245606h5"><span><div dir="ltr">On Wed, Jul 25, 2018 at 3:39 PM Alex L <<a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Looks like this works:<div><br></div><div><div>+++ b/src/experimental/filesystem/filesystem_common.h</div><div>@@ -393,7 +393,7 @@ bool set_file_times(const path& p, std::array<TimeSpec, 2> const& TS,</div><div> error_code& ec) {</div><div> #if !defined(_LIBCPP_USE_UTIMENSAT)</div><div> using namespace chrono;</div><div>- auto Convert = [](long nsec) {</div><div>+ auto Convert = [](long nsec) -> decltype(std::declval<::timeval>().tv_usec) {</div><div> return duration_cast<microseconds>(nanoseconds(nsec)).count();</div><div> };</div><div> struct ::timeval ConvertedTS[2] = {{TS[0].tv_sec, Convert(TS[0].tv_nsec)},</div></div><div><br></div><div>I will commit this fix in a couple of minutes.</div></div></blockquote><div><br></div></span><div>I think I would prefer an explicit cast to an implicit one since the narrowing is intended, and should be safe.</div><div><br></div><div>Maybe:</div><div><br></div><div>auto Convert [](long nsec) { </div><div> using int_type = decltype(::timeval::tv_usec);</div><div> auto dur = duration_cast<microseconds>(nanoseconds(nsec)).count();</div><div> return static_cast<int_type>(dur);</div><div>};</div><div><br></div><div>?</div></div></div></div></div></div></div></blockquote></div></div></div></div></blockquote></div></div></blockquote></div></div></div></div></blockquote></div></div></div></div></blockquote></div></div></blockquote></div></blockquote></div></div></blockquote></div></div></blockquote></div></blockquote></div></div></blockquote></div></div></blockquote></div></blockquote><div> </div></div></div></div></div>
</blockquote></div>