<div dir="ltr">Thanks for the fix!<br><br>Though maybe this isn't the best diagnostic experience - given that 'bar' isn't technically an overloaded function, but is a function template - worth doing something more precise here? (maybe not)<br><br>Wonder if there's similar handling for other diagnostic cases that could be used here (whether there's something that handles the equivalent: auto *f = &bar; situation with a better diagnostic & whether that infrastructure could be reused here)<br><br><div class="gmail_quote"><div dir="ltr">On Fri, Jul 6, 2018 at 5:22 PM Richard Trieu via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rtrieu<br>
Date: Fri Jul  6 17:17:25 2018<br>
New Revision: 336475<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=336475&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=336475&view=rev</a><br>
Log:<br>
Check returned type is valid before using it.<br>
<br>
Add a .isNull() check to returned QualType.  Fixes PR38077<br>
<br>
Modified:<br>
    cfe/trunk/lib/Sema/SemaCXXScopeSpec.cpp<br>
    cfe/trunk/test/SemaCXX/overloaded-name.cpp<br>
<br>
Modified: cfe/trunk/lib/Sema/SemaCXXScopeSpec.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaCXXScopeSpec.cpp?rev=336475&r1=336474&r2=336475&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaCXXScopeSpec.cpp?rev=336475&r1=336474&r2=336475&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Sema/SemaCXXScopeSpec.cpp (original)<br>
+++ cfe/trunk/lib/Sema/SemaCXXScopeSpec.cpp Fri Jul  6 17:17:25 2018<br>
@@ -846,6 +846,9 @@ bool Sema::ActOnCXXNestedNameSpecifierDe<br>
   assert(DS.getTypeSpecType() == DeclSpec::TST_decltype);<br>
<br>
   QualType T = BuildDecltypeType(DS.getRepAsExpr(), DS.getTypeSpecTypeLoc());<br>
+  if (T.isNull())<br>
+    return true;<br>
+<br>
   if (!T->isDependentType() && !T->getAs<TagType>()) {<br>
     Diag(DS.getTypeSpecTypeLoc(), diag::err_expected_class_or_namespace) <br>
       << T << getLangOpts().CPlusPlus;<br>
<br>
Modified: cfe/trunk/test/SemaCXX/overloaded-name.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/overloaded-name.cpp?rev=336475&r1=336474&r2=336475&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/overloaded-name.cpp?rev=336475&r1=336474&r2=336475&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/SemaCXX/overloaded-name.cpp (original)<br>
+++ cfe/trunk/test/SemaCXX/overloaded-name.cpp Fri Jul  6 17:17:25 2018<br>
@@ -28,3 +28,11 @@ namespace rdar9623945 {<br>
     }<br>
   };<br>
 }<br>
+<br>
+namespace PR38077 {<br>
+  template <class T> void bar() {} // expected-note {{possible target for call}}<br>
+<br>
+  int run() {<br>
+    decltype(bar)::does_not_exist; // expected-error {{reference to overloaded function could not be resolved; did you mean to call it?}}<br>
+  }<br>
+}<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div>