<div dir="ltr">Thank you for fixing the test!</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jun 28, 2018 at 2:23 AM Douglas Yung via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dyung<br>
Date: Wed Jun 27 17:19:12 2018<br>
New Revision: 335799<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=335799&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=335799&view=rev</a><br>
Log:<br>
Fixup test to compile with -frtti when trying to use typeid() as the PS4 does not have it on by default and it was failing on the PS4 linux bot because of this.<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/unittests/clang-tidy/ExprMutationAnalyzerTest.cpp<br>
<br>
Modified: clang-tools-extra/trunk/unittests/clang-tidy/ExprMutationAnalyzerTest.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/unittests/clang-tidy/ExprMutationAnalyzerTest.cpp?rev=335799&r1=335798&r2=335799&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/unittests/clang-tidy/ExprMutationAnalyzerTest.cpp?rev=335799&r1=335798&r2=335799&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/unittests/clang-tidy/ExprMutationAnalyzerTest.cpp (original)<br>
+++ clang-tools-extra/trunk/unittests/clang-tidy/ExprMutationAnalyzerTest.cpp Wed Jun 27 17:19:12 2018<br>
@@ -579,8 +579,10 @@ TEST(ExprMutationAnalyzerTest, Unevaluat<br>
   Results = match(withEnclosingCompound(declRefTo("x")), AST->getASTContext());<br>
   EXPECT_FALSE(isMutated(Results, AST.get()));<br>
<br>
-  AST = tooling::buildASTFromCode("namespace std { class type_info; }"<br>
-                                  "void f() { int x; typeid(x = 10); }");<br>
+  AST = <br>
+    tooling::buildASTFromCodeWithArgs("namespace std { class type_info; }"<br>
+                                     "void f() { int x; typeid(x = 10); }",<br>
+                                     std::vector<std::string> ({"-frtti"}));<br>
   Results = match(withEnclosingCompound(declRefTo("x")), AST->getASTContext());<br>
   EXPECT_FALSE(isMutated(Results, AST.get()));<br>
<br>
@@ -596,10 +598,11 @@ TEST(ExprMutationAnalyzerTest, NotUneval<br>
       match(withEnclosingCompound(declRefTo("x")), AST->getASTContext());<br>
   EXPECT_THAT(mutatedBy(Results, AST.get()), ElementsAre("x++"));<br>
<br>
-  AST = tooling::buildASTFromCode(<br>
+  AST = tooling::buildASTFromCodeWithArgs(<br>
       "namespace std { class type_info; }"<br>
       "struct A { virtual ~A(); }; struct B : A {};"<br>
-      "struct X { A& f(); }; void f() { X x; typeid(x.f()); }");<br>
+      "struct X { A& f(); }; void f() { X x; typeid(x.f()); }",<br>
+      std::vector<std::string> ({"-frtti"}));<br>
   Results = match(withEnclosingCompound(declRefTo("x")), AST->getASTContext());<br>
   EXPECT_THAT(mutatedBy(Results, AST.get()), ElementsAre("x.f()"));<br>
 }<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>