<div dir="ltr">Hi Roman,<div><br></div><div>Definitely something different in our configs, but it wasn't just me - a couple of colleagues have mentioned those tests as being broken for a while!</div><div><br></div><div>The problem is the lack of compilation database, so I can imagine it can depend on filesystem layout, e.g. whether you have a separate build/source directory. (Potentially the CDB from llvm itself may be picked up or not)</div><div><br></div><div>I can't tell from your lit output whether clang-tidy or FileCheck failed, what does this command return for you?</div><div><br></div><div><div>bin/clang-tidy -enable-check-profile -checks='-*,readability-function-size' ../src/llvm/tools/clang/tools/extra/test/clang-tid</div><div>y/clang-tidy-enable-check-profile-one-tu.cpp --</div></div><div><br></div><div>(adjust path as needed)</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jun 5, 2018 at 12:30 PM Roman Lebedev <<a href="mailto:lebedev.ri@gmail.com">lebedev.ri@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This is strange.<br>
<br>
First, i'm pretty sure the test worked for me before.<br>
Second, this commit actually *breaks* those two tests for me:<br>
<br>
$ ninja check-clang-tools<br>
[0/1] Running the Clang extra tools' regression tests<br>
FAIL: Clang Tools ::<br>
clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp (123 of 867)<br>
******************** TEST 'Clang Tools ::<br>
clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp' FAILED<br>
********************<br>
Script:<br>
--<br>
: 'RUN: at line 1';   clang-tidy -enable-check-profile<br>
-checks='-*,readability-function-size'<br>
/build/clang-tools-extra/test/clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp<br>
-- 2>&1 | FileCheck --match-full-lines<br>
-implicit-check-not='{{warning:|error:}}' /build/clang<br>
-tools-extra/test/clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp<br>
--<br>
Exit Code: 2<br>
<br>
Command Output (stderr):<br>
--<br>
FileCheck error: '-' is empty.<br>
FileCheck command line:  FileCheck --match-full-lines<br>
-implicit-check-not={{warning:|error:}}<br>
/build/clang-tools-extra/test/clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp<br>
<br>
--<br>
<br>
********************<br>
FAIL: Clang Tools ::<br>
clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp (125 of 867)<br>
******************** TEST 'Clang Tools ::<br>
clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp' FAILED<br>
********************<br>
Script:<br>
--<br>
: 'RUN: at line 1';   clang-tidy -enable-check-profile<br>
-checks='-*,readability-function-size'<br>
/build/clang-tools-extra/test/clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp<br>
/build/clang-tools-extra/test/clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp<br>
-- 2>&1 |<br>
FileCheck --match-full-lines -implicit-check-not='{{warning:|error:}}'<br>
/build/clang-tools-extra/test/clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp<br>
--<br>
Exit Code: 2<br>
<br>
Command Output (stderr):<br>
--<br>
FileCheck error: '-' is empty.<br>
FileCheck command line:  FileCheck --match-full-lines<br>
-implicit-check-not={{warning:|error:}}<br>
/build/clang-tools-extra/test/clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp<br>
<br>
--<br>
<br>
Roman.<br>
<br>
On Tue, Jun 5, 2018 at 12:42 PM, Sam McCall via cfe-commits<br>
<<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br>
> Author: sammccall<br>
> Date: Tue Jun  5 02:42:06 2018<br>
> New Revision: 333994<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=333994&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=333994&view=rev</a><br>
> Log:<br>
> [clang-tidy] fix broken test (no compile command) from r331763<br>
><br>
> Modified:<br>
>     clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp<br>
>     clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp<br>
><br>
> Modified: clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp?rev=333994&r1=333993&r2=333994&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp?rev=333994&r1=333993&r2=333994&view=diff</a><br>
> ==============================================================================<br>
> --- clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp (original)<br>
> +++ clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp Tue Jun  5 02:42:06 2018<br>
> @@ -1,4 +1,4 @@<br>
> -// RUN: clang-tidy -enable-check-profile -checks='-*,readability-function-size' %s 2>&1 | FileCheck --match-full-lines -implicit-check-not='{{warning:|error:}}' %s<br>
> +// RUN: clang-tidy -enable-check-profile -checks='-*,readability-function-size' %s -- 2>&1 | FileCheck --match-full-lines -implicit-check-not='{{warning:|error:}}' %s<br>
><br>
>  // CHECK: ===-------------------------------------------------------------------------===<br>
>  // CHECK-NEXT: {{.*}}  --- Name ---<br>
><br>
> Modified: clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp?rev=333994&r1=333993&r2=333994&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp?rev=333994&r1=333993&r2=333994&view=diff</a><br>
> ==============================================================================<br>
> --- clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp (original)<br>
> +++ clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp Tue Jun  5 02:42:06 2018<br>
> @@ -1,4 +1,4 @@<br>
> -// RUN: clang-tidy -enable-check-profile -checks='-*,readability-function-size' %s %s 2>&1 | FileCheck --match-full-lines -implicit-check-not='{{warning:|error:}}' %s<br>
> +// RUN: clang-tidy -enable-check-profile -checks='-*,readability-function-size' %s %s -- 2>&1 | FileCheck --match-full-lines -implicit-check-not='{{warning:|error:}}' %s<br>
><br>
>  // CHECK: ===-------------------------------------------------------------------------===<br>
>  // CHECK-NEXT: {{.*}}  --- Name ---<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>