<div dir="ltr">I think this code is probably dead since the stem is "ld.lld" for lld, not "lld".</div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Feb 11, 2017 at 7:22 PM, Davide Italiano via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Sat, Feb 11, 2017 at 4:19 PM, Rui Ueyama <<a href="mailto:ruiu@google.com">ruiu@google.com</a>> wrote:<br>
> On Sat, Feb 11, 2017 at 3:44 PM, Davide Italiano via cfe-commits<br>
> <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
>><br>
>> Author: davide<br>
>> Date: Sat Feb 11 17:44:37 2017<br>
>> New Revision: 294879<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=294879&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=294879&view=rev</a><br>
>> Log:<br>
>> [Driver] Use stem() and not filename().<br>
>><br>
>> On Windows the filename might have an extension, namely<br>
>> `.exe`, so the search will fail. Sorry, I don't have a<br>
>> good way to test this as it seems to fail only in some<br>
>> weird configurations. r284430 has the same modification<br>
>> for Fuchsia.<br>
>><br>
>> Modified:<br>
>>     cfe/trunk/lib/Driver/Tools.cpp<br>
>><br>
>> Modified: cfe/trunk/lib/Driver/Tools.cpp<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=294879&r1=294878&r2=294879&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/lib/Driver/<wbr>Tools.cpp?rev=294879&r1=<wbr>294878&r2=294879&view=diff</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- cfe/trunk/lib/Driver/Tools.cpp (original)<br>
>> +++ cfe/trunk/lib/Driver/Tools.cpp Sat Feb 11 17:44:37 2017<br>
>> @@ -10163,7 +10163,7 @@ void gnutools::Linker::<wbr>ConstructJob(Comp<br>
>>    Args.ClaimAllArgs(options::<wbr>OPT_w);<br>
>><br>
>>    const char *Exec = Args.MakeArgString(ToolChain.<wbr>GetLinkerPath());<br>
>> -  if (llvm::sys::path::filename(<wbr>Exec) == "lld") {<br>
>> +  if (llvm::sys::path::stem(Exec) == "lld") {<br>
>>      CmdArgs.push_back("-flavor");<br>
>>      CmdArgs.push_back("old-gnu");<br>
><br>
<br>
</div></div>Probably not, I'm just reducing diffs with out local branch. I think<br>
we can remove it altogether.<br>
<span class="HOEnZb"><font color="#888888"><br>
-- <br>
Davide<br>
<br>
"There are no solved problems; there are only problems that are more<br>
or less solved" -- Henri Poincare<br>
</font></span><div class="HOEnZb"><div class="h5">______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>