<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Mon, May 7, 2018 at 12:57 PM Keane, Erich <<a href="mailto:erich.keane@intel.com">erich.keane@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div class="m_580199015790527053WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">I don’t believe the member initialization for bitfields (of which all the ‘0’ values are) happened until C++17, right?</span></p></div></div></blockquote><div><br>Ah, fair point - I hadn't looked at the types, just what was visible in the patch. (& I don't especially know/recall which standard/etc supported member initialization of bitfields, but I could certainly believe it didn't happen until '17)<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div class="m_580199015790527053WordSection1"><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"> I could definitely member initialize the
two enum fields though.</span></p></div></div></blockquote><div><br>*nod*<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div class="m_580199015790527053WordSection1"><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u><u></u></span></p>
<p class="MsoNormal"><a name="m_580199015790527053__MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></a></p>
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> David Blaikie [mailto:<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>]
<br>
<b>Sent:</b> Monday, May 7, 2018 12:03 PM<br>
<b>To:</b> Keane, Erich <<a href="mailto:erich.keane@intel.com" target="_blank">erich.keane@intel.com</a>><br>
<b>Cc:</b> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<b>Subject:</b> Re: r331536 - [NFC]Convert Class to use member initialization instead of inline.<u></u><u></u></span></p></div></div><div lang="EN-US" link="blue" vlink="purple"><div class="m_580199015790527053WordSection1">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Perhaps this should use non-static data member initializers instead?<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Fri, May 4, 2018 at 9:23 AM Erich Keane via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">Author: erichkeane<br>
Date: Fri May 4 09:19:53 2018<br>
New Revision: 331536<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=331536&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=331536&view=rev</a><br>
Log:<br>
[NFC]Convert Class to use member initialization instead of inline.<br>
<br>
Modified:<br>
cfe/trunk/include/clang/Frontend/DependencyOutputOptions.h<br>
<br>
Modified: cfe/trunk/include/clang/Frontend/DependencyOutputOptions.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Frontend/DependencyOutputOptions.h?rev=331536&r1=331535&r2=331536&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Frontend/DependencyOutputOptions.h?rev=331536&r1=331535&r2=331536&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Frontend/DependencyOutputOptions.h (original)<br>
+++ cfe/trunk/include/clang/Frontend/DependencyOutputOptions.h Fri May 4 09:19:53 2018<br>
@@ -65,15 +65,11 @@ public:<br>
std::string ModuleDependencyOutputDir;<br>
<br>
public:<br>
- DependencyOutputOptions() {<br>
- IncludeSystemHeaders = 0;<br>
- ShowHeaderIncludes = 0;<br>
- UsePhonyTargets = 0;<br>
- AddMissingHeaderDeps = 0;<br>
- IncludeModuleFiles = 0;<br>
- ShowIncludesDest = ShowIncludesDestination::None;<br>
- OutputFormat = DependencyOutputFormat::Make;<br>
- }<br>
+ DependencyOutputOptions()<br>
+ : IncludeSystemHeaders(0), ShowHeaderIncludes(0), UsePhonyTargets(0),<br>
+ AddMissingHeaderDeps(0), IncludeModuleFiles(0),<br>
+ ShowIncludesDest(ShowIncludesDestination::None),<br>
+ OutputFormat(DependencyOutputFormat::Make) {}<br>
};<br>
<br>
} // end namespace clang<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><u></u><u></u></p>
</blockquote>
</div>
</div></div></blockquote></div></div>