<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 12 April 2018 at 07:20, Jan Korous via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space">Hi Richard,<div><br></div><div>Here you are:</div><div><a href="https://reviews.llvm.org/D45569" target="_blank">https://reviews.llvm.org/<wbr>D45569</a><br><div><br></div><div>I am now thinking if it makes sense to output this warning for pre-17 standards:</div><div><br></div><div><div>warning: incrementing expression of type bool is deprecated and incompatible with C++17</div><div><br></div><div>Produced in:</div><div><br></div><div>SemaExpr.cpp</div><div><br></div><div>static QualType CheckIncrementDecrementOperand</div><div><br></div><div> // Increment of bool sets it to true, but is deprecated.</div><div> S.Diag(OpLoc, S.getLangOpts().CPlusPlus17 ? diag::ext_increment_bool</div><div> : diag::warn_increment_bool)</div></div><div><br></div><div>What do you think?</div></div></div></blockquote><div><br></div><div>Seems like a good idea to me, thanks!</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div><span class="HOEnZb"><font color="#888888"><div>Jan</div></font></span><div><div class="h5"><div><br><blockquote type="cite"><div>On 11 Apr 2018, at 15:19, Richard Smith <<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>> wrote:</div><br class="m_-110199144372105001Apple-interchange-newline"><div><div dir="auto">While you're here... ++ should not be available for bool in C++17 onwards. :)</div><br><div class="gmail_quote"><div dir="ltr">On Wed, 11 Apr 2018, 14:39 Jan Korous via cfe-commits, <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: jkorous<br>
Date: Wed Apr 11 06:36:29 2018<br>
New Revision: 329804<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=329804&view=rev" rel="noreferrer noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=329804&view=rev</a><br>
Log:<br>
[Sema] Fix built-in decrement operator overload resolution<br>
<br>
C++ [over.built] p4:<br>
<br>
"For every pair (T, VQ), where T is an arithmetic type other than bool, and VQ is either volatile or empty, there exist candidate operator functions of the form<br>
<br>
VQ T& operator--(VQ T&);<br>
T operator--(VQ T&, int);<br>
"<br>
The bool type is in position LastPromotedIntegralType in BuiltinOperatorOverloadBuilder<wbr>::getArithmeticType::<wbr>ArithmeticTypes, but addPlusPlusMinusMinusArithmeti<wbr>cOverloads() was expecting it at position 0.<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D44988" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D44988</a><br>
<br>
<a>rdar://problem/34255516</a><br>
<br>
Modified:<br>
cfe/trunk/lib/Sema/<wbr>SemaOverload.cpp<br>
cfe/trunk/test/SemaCXX/<wbr>overloaded-builtin-operators.<wbr>cpp<br>
<br>
Modified: cfe/trunk/lib/Sema/<wbr>SemaOverload.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaOverload.cpp?rev=329804&r1=329803&r2=329804&view=diff" rel="noreferrer noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/lib/Sema/<wbr>SemaOverload.cpp?rev=329804&<wbr>r1=329803&r2=329804&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/lib/Sema/<wbr>SemaOverload.cpp (original)<br>
+++ cfe/trunk/lib/Sema/<wbr>SemaOverload.cpp Wed Apr 11 06:36:29 2018<br>
@@ -7796,10 +7796,12 @@ public:<br>
if (!<wbr>HasArithmeticOrEnumeralCandida<wbr>teType)<br>
return;<br>
<br>
- for (unsigned Arith = (Op == OO_PlusPlus? 0 : 1);<br>
- Arith < NumArithmeticTypes; ++Arith) {<br>
+ for (unsigned Arith = 0; Arith < NumArithmeticTypes; ++Arith) {<br>
+ const auto TypeOfT = ArithmeticTypes[Arith];<br>
+ if (Op == OO_MinusMinus && TypeOfT == S.Context.BoolTy)<br>
+ continue;<br>
<wbr>addPlusPlusMinusMinusStyleOver<wbr>loads(<br>
- ArithmeticTypes[Arith],<br>
+ TypeOfT,<br>
VisibleTypeConversionsQuals.<wbr>hasVolatile(),<br>
VisibleTypeConversionsQuals.<wbr>hasRestrict());<br>
}<br>
<br>
Modified: cfe/trunk/test/SemaCXX/<wbr>overloaded-builtin-operators.<wbr>cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/overloaded-builtin-operators.cpp?rev=329804&r1=329803&r2=329804&view=diff" rel="noreferrer noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/test/<wbr>SemaCXX/overloaded-builtin-<wbr>operators.cpp?rev=329804&r1=<wbr>329803&r2=329804&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/test/SemaCXX/<wbr>overloaded-builtin-operators.<wbr>cpp (original)<br>
+++ cfe/trunk/test/SemaCXX/<wbr>overloaded-builtin-operators.<wbr>cpp Wed Apr 11 06:36:29 2018<br>
@@ -62,6 +62,10 @@ void f(Short s, Long l, Enum1 e1, Enum2<br>
// FIXME: should pass (void)static_cast<no&>(islong(<wbr>e1 % e2));<br>
}<br>
<br>
+struct BoolRef {<br>
+ operator bool&();<br>
+};<br>
+<br>
struct ShortRef { // expected-note{{candidate function (the implicit copy assignment operator) not viable}}<br>
#if __cplusplus >= 201103L // C++11 or later<br>
// expected-note@-2 {{candidate function (the implicit move assignment operator) not viable}}<br>
@@ -73,6 +77,10 @@ struct LongRef {<br>
operator volatile long&();<br>
};<br>
<br>
+struct FloatRef {<br>
+ operator float&();<br>
+};<br>
+<br>
struct XpmfRef { // expected-note{{candidate function (the implicit copy assignment operator) not viable}}<br>
#if __cplusplus >= 201103L // C++11 or later<br>
// expected-note@-2 {{candidate function (the implicit move assignment operator) not viable}}<br>
@@ -84,13 +92,19 @@ struct E2Ref {<br>
operator E2&();<br>
};<br>
<br>
-void g(ShortRef sr, LongRef lr, E2Ref e2_ref, XpmfRef pmf_ref) {<br>
+void g(BoolRef br, ShortRef sr, LongRef lr, FloatRef fr, E2Ref e2_ref, XpmfRef pmf_ref) {<br>
// C++ [over.built]p3<br>
short s1 = sr++;<br>
<br>
- // C++ [over.built]p3<br>
+ // C++ [over.built]p4<br>
long l1 = lr--;<br>
<br>
+ // C++ [over.built]p4<br>
+ float f1 = fr--;<br>
+<br>
+ // C++ [over.built]p4<br>
+ bool b2 = br--; // expected-error{{cannot decrement value of type 'BoolRef'}}<br>
+<br>
// C++ [over.built]p18<br>
short& sr1 = (sr *= lr);<br>
volatile long& lr1 = (lr *= sr);<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" rel="noreferrer" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div>
</div></blockquote></div><br></div></div></div></div><br>______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div></div>