<div dir="ltr">So you're happy with this opt-in version?</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 24, 2018 at 1:29 PM, Marshall Clow via Phabricator via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">mclow.lists added a comment.<br>
<span class=""><br>
In <a href="https://reviews.llvm.org/D45179#1056183" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D45179#1056183</a>, @rjmccall wrote:<br>
<br>
</span><span class="">> Is Marshall arguing that the standard doesn't allow compilers to warn about failing to use these function results prior to C++17?  Because I don't think that's true; warnings are thoroughly non-normative.<br>
<br>
<br>
</span>I have proposed to add different forms of "nodiscard" warnings to libc++ in the past, and received **strong** pushback from people who:<br>
<br>
- Compile with -Werror<br>
- Don't want to change their code.<br>
<br>
I'm not willing to have that argument again.<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
Repository:<br>
  rCXX libc++<br>
<br>
<a href="https://reviews.llvm.org/D45179" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D45179</a><br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>