<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi Richard,<div class=""><br class=""></div><div class="">Here you are:</div><div class=""><a href="https://reviews.llvm.org/D45569" class="">https://reviews.llvm.org/D45569</a><br class=""><div><br class=""></div><div>I am now thinking if it makes sense to output this warning for pre-17 standards:</div><div><br class=""></div><div><div>warning: incrementing expression of type bool is deprecated and incompatible with C++17</div><div><br class=""></div><div>Produced in:</div><div><br class=""></div><div>SemaExpr.cpp</div><div><br class=""></div><div>static QualType CheckIncrementDecrementOperand</div><div><br class=""></div><div> // Increment of bool sets it to true, but is deprecated.</div><div> S.Diag(OpLoc, S.getLangOpts().CPlusPlus17 ? diag::ext_increment_bool</div><div> : diag::warn_increment_bool)</div></div><div><br class=""></div><div>What do you think?</div><div><br class=""></div><div>Jan</div><div><br class=""><blockquote type="cite" class=""><div class="">On 11 Apr 2018, at 15:19, Richard Smith <<a href="mailto:richard@metafoo.co.uk" class="">richard@metafoo.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="auto" class="">While you're here... ++ should not be available for bool in C++17 onwards. :)</div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Wed, 11 Apr 2018, 14:39 Jan Korous via cfe-commits, <<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: jkorous<br class="">
Date: Wed Apr 11 06:36:29 2018<br class="">
New Revision: 329804<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=329804&view=rev" rel="noreferrer noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=329804&view=rev</a><br class="">
Log:<br class="">
[Sema] Fix built-in decrement operator overload resolution<br class="">
<br class="">
C++ [over.built] p4:<br class="">
<br class="">
"For every pair (T, VQ), where T is an arithmetic type other than bool, and VQ is either volatile or empty, there exist candidate operator functions of the form<br class="">
<br class="">
VQ T& operator--(VQ T&);<br class="">
T operator--(VQ T&, int);<br class="">
"<br class="">
The bool type is in position LastPromotedIntegralType in BuiltinOperatorOverloadBuilder::getArithmeticType::ArithmeticTypes, but addPlusPlusMinusMinusArithmeticOverloads() was expecting it at position 0.<br class="">
<br class="">
Differential Revision: <a href="https://reviews.llvm.org/D44988" rel="noreferrer noreferrer" target="_blank" class="">https://reviews.llvm.org/D44988</a><br class="">
<br class="">
<a href="rdar://problem/34255516" class="">rdar://problem/34255516</a><br class="">
<br class="">
Modified:<br class="">
cfe/trunk/lib/Sema/SemaOverload.cpp<br class="">
cfe/trunk/test/SemaCXX/overloaded-builtin-operators.cpp<br class="">
<br class="">
Modified: cfe/trunk/lib/Sema/SemaOverload.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaOverload.cpp?rev=329804&r1=329803&r2=329804&view=diff" rel="noreferrer noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaOverload.cpp?rev=329804&r1=329803&r2=329804&view=diff</a><br class="">
==============================================================================<br class="">
--- cfe/trunk/lib/Sema/SemaOverload.cpp (original)<br class="">
+++ cfe/trunk/lib/Sema/SemaOverload.cpp Wed Apr 11 06:36:29 2018<br class="">
@@ -7796,10 +7796,12 @@ public:<br class="">
if (!HasArithmeticOrEnumeralCandidateType)<br class="">
return;<br class="">
<br class="">
- for (unsigned Arith = (Op == OO_PlusPlus? 0 : 1);<br class="">
- Arith < NumArithmeticTypes; ++Arith) {<br class="">
+ for (unsigned Arith = 0; Arith < NumArithmeticTypes; ++Arith) {<br class="">
+ const auto TypeOfT = ArithmeticTypes[Arith];<br class="">
+ if (Op == OO_MinusMinus && TypeOfT == S.Context.BoolTy)<br class="">
+ continue;<br class="">
addPlusPlusMinusMinusStyleOverloads(<br class="">
- ArithmeticTypes[Arith],<br class="">
+ TypeOfT,<br class="">
VisibleTypeConversionsQuals.hasVolatile(),<br class="">
VisibleTypeConversionsQuals.hasRestrict());<br class="">
}<br class="">
<br class="">
Modified: cfe/trunk/test/SemaCXX/overloaded-builtin-operators.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/overloaded-builtin-operators.cpp?rev=329804&r1=329803&r2=329804&view=diff" rel="noreferrer noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/overloaded-builtin-operators.cpp?rev=329804&r1=329803&r2=329804&view=diff</a><br class="">
==============================================================================<br class="">
--- cfe/trunk/test/SemaCXX/overloaded-builtin-operators.cpp (original)<br class="">
+++ cfe/trunk/test/SemaCXX/overloaded-builtin-operators.cpp Wed Apr 11 06:36:29 2018<br class="">
@@ -62,6 +62,10 @@ void f(Short s, Long l, Enum1 e1, Enum2<br class="">
// FIXME: should pass (void)static_cast<no&>(islong(e1 % e2));<br class="">
}<br class="">
<br class="">
+struct BoolRef {<br class="">
+ operator bool&();<br class="">
+};<br class="">
+<br class="">
struct ShortRef { // expected-note{{candidate function (the implicit copy assignment operator) not viable}}<br class="">
#if __cplusplus >= 201103L // C++11 or later<br class="">
// expected-note@-2 {{candidate function (the implicit move assignment operator) not viable}}<br class="">
@@ -73,6 +77,10 @@ struct LongRef {<br class="">
operator volatile long&();<br class="">
};<br class="">
<br class="">
+struct FloatRef {<br class="">
+ operator float&();<br class="">
+};<br class="">
+<br class="">
struct XpmfRef { // expected-note{{candidate function (the implicit copy assignment operator) not viable}}<br class="">
#if __cplusplus >= 201103L // C++11 or later<br class="">
// expected-note@-2 {{candidate function (the implicit move assignment operator) not viable}}<br class="">
@@ -84,13 +92,19 @@ struct E2Ref {<br class="">
operator E2&();<br class="">
};<br class="">
<br class="">
-void g(ShortRef sr, LongRef lr, E2Ref e2_ref, XpmfRef pmf_ref) {<br class="">
+void g(BoolRef br, ShortRef sr, LongRef lr, FloatRef fr, E2Ref e2_ref, XpmfRef pmf_ref) {<br class="">
// C++ [over.built]p3<br class="">
short s1 = sr++;<br class="">
<br class="">
- // C++ [over.built]p3<br class="">
+ // C++ [over.built]p4<br class="">
long l1 = lr--;<br class="">
<br class="">
+ // C++ [over.built]p4<br class="">
+ float f1 = fr--;<br class="">
+<br class="">
+ // C++ [over.built]p4<br class="">
+ bool b2 = br--; // expected-error{{cannot decrement value of type 'BoolRef'}}<br class="">
+<br class="">
// C++ [over.built]p18<br class="">
short& sr1 = (sr *= lr);<br class="">
volatile long& lr1 = (lr *= sr);<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" rel="noreferrer" class="">cfe-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></body></html>