<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Wed, Apr 11, 2018 at 10:16 AM Haojian Wu via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: hokein<br>
Date: Wed Apr 11 01:13:07 2018<br>
New Revision: 329784<br>
...<br>==============================================================================<br>
--- cfe/trunk/include/clang/Tooling/Execution.h (original)<br>
+++ cfe/trunk/include/clang/Tooling/Execution.h Wed Apr 11 01:13:07 2018<br><br>
@@ -45,20 +46,30 @@ class ToolResults {<br>
 public:<br>
   virtual ~ToolResults() = default;<br>
   virtual void addResult(StringRef Key, StringRef Value) = 0;<br>
-  virtual std::vector<std::pair<std::string, std::string>> AllKVResults() = 0;<br>
+  virtual std::vector<std::pair<llvm::StringRef, llvm::StringRef>><br>
+  AllKVResults() = 0;<br></blockquote><div><br></div><div><span style="color:rgb(0,0,0);font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:left;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">I would add a comment re: lifetime of the strings pointed by the return value.</span></div><div><br></div></div></div>