<div dir="ltr">Best if you can use the SubVersion revision number rather than a git hash when reverting. There's a utility in the LLVM project to help with this (llvm/utils/git-svn/git-svnrevert)</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Apr 6, 2018 at 12:16 PM George Karpenkov via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: george.karpenkov<br>
Date: Fri Apr  6 12:14:05 2018<br>
New Revision: 329445<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=329445&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=329445&view=rev</a><br>
Log:<br>
Revert "[analyzer] Remove an unused variable"<br>
<br>
This reverts commit 2fa3e3edc4ed6547cc4ce46a8c79d1891a5b3b36.<br>
<br>
Removed the wrong variable.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Analysis/LiveVariables.cpp<br>
<br>
Modified: cfe/trunk/lib/Analysis/LiveVariables.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/LiveVariables.cpp?rev=329445&r1=329444&r2=329445&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/LiveVariables.cpp?rev=329445&r1=329444&r2=329445&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Analysis/LiveVariables.cpp (original)<br>
+++ cfe/trunk/lib/Analysis/LiveVariables.cpp Fri Apr  6 12:14:05 2018<br>
@@ -381,7 +381,7 @@ void TransferFunctions::VisitBlockExpr(B<br>
 void TransferFunctions::VisitDeclRefExpr(DeclRefExpr *DR) {<br>
   const Decl* D = DR->getDecl();<br>
   bool InAssignment = LV.inAssignment[DR];<br>
-  if (isa<BindingDecl>(D)) {<br>
+  if (const auto *BD = dyn_cast<BindingDecl>(D)) {<br>
     if (!InAssignment)<br>
       val.liveBindings = LV.BSetFact.add(val.liveBindings, BD);<br>
   } else if (const auto *VD = dyn_cast<VarDecl>(D)) {<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>