<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Tue, Apr 3, 2018 at 1:52 PM Alex Lorenz via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: arphaman<br>
Date: Tue Apr  3 13:50:05 2018<br>
New Revision: 329110<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=329110&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=329110&view=rev</a><br>
Log:<br>
[driver][darwin] Do not infer -simulator environment for non-simulator SDKs<br></blockquote><div><br></div><div>I know you added a REQUIRES line to these tests, but I think there is a much better way:</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
--- cfe/trunk/test/Driver/darwin-sdkroot.c (original)<br>
+++ cfe/trunk/test/Driver/darwin-sdkroot.c Tue Apr  3 13:50:05 2018<br>
@@ -51,12 +51,21 @@<br>
 // CHECK-IPHONE: "-triple" "arm64-apple-ios8.0.0"<br>
 // CHECK-IPHONE: ld<br>
 // CHECK-IPHONE: "-iphoneos_version_min" "8.0.0"<br>
+// RUN: env SDKROOT=%t/SDKs/iPhoneOS8.0.0.sdk %clang %s -### 2>&1 \<br></blockquote><div><br></div><div>Instead of just running %clang, actually pass the `-target` you want to it like we do in the below invocation and the other invocations in this file.</div><div><br></div><div>We shouldn't lose driver testing on other systems as long as you can specify the desired target.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+// RUN:   | FileCheck --check-prefix=CHECK-IPHONE-X86 %s<br>
+// CHECK-IPHONE-X86: clang<br>
+// CHECK-IPHONE-X86: "-cc1"<br>
+// CHECK-IPHONE-X86: -apple-ios8.0.0"<br>
+// CHECK-IPHONE-X86: ld<br>
+// CHECK-IPHONE-X86: "-iphoneos_version_min" "8.0.0"<br>
 //<br>
 //<br>
 // RUN: rm -rf %t/SDKs/iPhoneSimulator8.0.sdk<br>
 // RUN: mkdir -p %t/SDKs/iPhoneSimulator8.0.sdk<br>
 // RUN: env SDKROOT=%t/SDKs/iPhoneSimulator8.0.sdk %clang -target x86_64-apple-darwin %s -### 2>&1 \<br>
 // RUN:   | FileCheck --check-prefix=CHECK-SIMULATOR %s<br>
+// RUN: env SDKROOT=%t/SDKs/iPhoneSimulator8.0.sdk %clang -arch x86_64 %s -### 2>&1 \<br>
+// RUN:   | FileCheck --check-prefix=CHECK-SIMULATOR %s<br>
 //<br>
 // CHECK-SIMULATOR: clang<br>
 // CHECK-SIMULATOR: "-cc1"<br>
@@ -74,3 +83,49 @@<br>
 // CHECK-MACOSX: "-triple" "x86_64-apple-macosx10.10.0"<br>
 // CHECK-MACOSX: ld<br>
 // CHECK-MACOSX: "-macosx_version_min" "10.10.0"<br>
+<br>
+// RUN: rm -rf %t/SDKs/WatchOS3.0.sdk<br>
+// RUN: mkdir -p %t/SDKs/WatchOS3.0.sdk<br>
+// RUN: env SDKROOT=%t/SDKs/WatchOS3.0.sdk %clang %s -### 2>&1 \<br>
+// RUN:   | FileCheck --check-prefix=CHECK-WATCH %s<br>
+//<br>
+// CHECK-WATCH: clang<br>
+// CHECK-WATCH: "-cc1"<br>
+// CHECK-WATCH: -apple-watchos3.0.0"<br>
+// CHECK-WATCH: ld<br>
+// CHECK-WATCH: "-watchos_version_min" "3.0.0"<br>
+//<br>
+//<br>
+// RUN: rm -rf %t/SDKs/WatchSimulator3.0.sdk<br>
+// RUN: mkdir -p %t/SDKs/WatchSimulator3.0.sdk<br>
+// RUN: env SDKROOT=%t/SDKs/WatchSimulator3.0.sdk %clang %s -### 2>&1 \<br>
+// RUN:   | FileCheck --check-prefix=CHECK-WATCH-SIMULATOR %s<br>
+//<br>
+// CHECK-WATCH-SIMULATOR: clang<br>
+// CHECK-WATCH-SIMULATOR: "-cc1"<br>
+// CHECK-WATCH-SIMULATOR: -apple-watchos3.0.0-simulator"<br>
+// CHECK-WATCH-SIMULATOR: ld<br>
+// CHECK-WATCH-SIMULATOR: "-watchos_simulator_version_min" "3.0.0"<br>
+<br>
+// RUN: rm -rf %t/SDKs/AppleTVOS10.0.sdk<br>
+// RUN: mkdir -p %t/SDKs/AppleTVOS10.0.sdk<br>
+// RUN: env SDKROOT=%t/SDKs/AppleTVOS10.0.sdk %clang %s -### 2>&1 \<br>
+// RUN:   | FileCheck --check-prefix=CHECK-TV %s<br>
+//<br>
+// CHECK-TV: clang<br>
+// CHECK-TV: "-cc1"<br>
+// CHECK-TV: -apple-tvos10.0.0"<br>
+// CHECK-TV: ld<br>
+// CHECK-TV: "-tvos_version_min" "10.0.0"<br>
+//<br>
+//<br>
+// RUN: rm -rf %t/SDKs/AppleTVSimulator10.0.sdk<br>
+// RUN: mkdir -p %t/SDKs/AppleTVSimulator10.0.sdk<br>
+// RUN: env SDKROOT=%t/SDKs/AppleTVSimulator10.0.sdk %clang %s -### 2>&1 \<br>
+// RUN:   | FileCheck --check-prefix=CHECK-TV-SIMULATOR %s<br>
+//<br>
+// CHECK-TV-SIMULATOR: clang<br>
+// CHECK-TV-SIMULATOR: "-cc1"<br>
+// CHECK-TV-SIMULATOR: -apple-tvos10.0.0-simulator"<br>
+// CHECK-TV-SIMULATOR: ld<br>
+// CHECK-TV-SIMULATOR: "-tvos_simulator_version_min" "10.0.0"<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div>