<div dir="ltr">You didn't update <span style="font-size:12.8px">allocator.member</span><wbr style="font-size:12.8px"><span style="font-size:12.8px">s\construct.pass.cpp in your patch. </span><div><br class="gmail-Apple-interchange-newline"></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Mar 24, 2018 at 6:41 PM, Eric Fiselier <span dir="ltr"><<a href="mailto:eric@efcs.ca" target="_blank">eric@efcs.ca</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Still?<div><br></div><div>I would of hoped this patch fixed it.</div><div><br></div><div>Could you provide the test output?</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>/Eric</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Mar 24, 2018 at 4:39 PM, Francois Pichet <span dir="ltr"><<a href="mailto:pichet2000@gmail.com" target="_blank">pichet2000@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>I am seeing failure on this test too.</div><div>    test\std\utilities\memory\defa<wbr>ult.allocator\allocator.member<wbr>s\construct.pass.cpp<br></div><div class="gmail_extra"><br></div><div class="gmail_extra">For the same reason : new optimized away.</div><span><div class="gmail_extra"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 22, 2018 at 5:28 PM, Eric Fiselier via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ericwf<br>
Date: Thu Mar 22 14:28:09 2018<br>
New Revision: 328245<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=328245&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=328245&view=rev</a><br>
Log:<br>
Use DoNotOptimize to prevent new/delete elision.<br>
<br>
The new/delete tests, in particular those which test replacement<br>
functions, often fail when the optimizer is enabled because the<br>
calls to new/delete may be optimized away, regardless of their side-effects.<br>
<br>
This patch converts the tests to use DoNotOptimize in order to prevent<br>
the elision.<br>
<br><br>
</blockquote></div><br></div></span></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>