<div dir="ltr">Eric,<div>Any chance you could have one more look at this and let me know if the patch is acceptable?</div><div><br></div><div>Thanks,</div><div>Mike</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 5, 2018 at 4:16 PM, Mike Edwards via Phabricator <span dir="ltr"><<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">sqlbyme updated this revision to Diff 137104.<br>
sqlbyme added a comment.<br>
<br>
I copied what Eric did here: <a href="https://github.com/llvm-mirror/libcxx/commit/6878e852d1d26cca0abee3013822311cd894ca3e" rel="noreferrer" target="_blank">https://github.com/llvm-<wbr>mirror/libcxx/commit/<wbr>6878e852d1d26cca0abee301382231<wbr>1cd894ca3e</a>.  I have tested this on our bots and the fix works fine.<br>
<span class=""><br>
<br>
<a href="https://reviews.llvm.org/D44103" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D44103</a><br>
<br>
Files:<br>
  test/std/strings/basic.string/<wbr>string.cons/iter_alloc_<wbr>deduction.fail.cpp<br>
<br>
<br>
Index: test/std/strings/basic.string/<wbr>string.cons/iter_alloc_<wbr>deduction.fail.cpp<br>
==============================<wbr>==============================<wbr>=======<br>
--- test/std/strings/basic.string/<wbr>string.cons/iter_alloc_<wbr>deduction.fail.cpp<br>
+++ test/std/strings/basic.string/<wbr>string.cons/iter_alloc_<wbr>deduction.fail.cpp<br>
</span>@@ -9,8 +9,7 @@<br>
<span class=""><br>
 // <string><br>
 // UNSUPPORTED: c++98, c++03, c++11, c++14<br>
</span>-// UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7, clang-3.8, clang-3.9, clang-4.0<br>
<span class="">-// UNSUPPORTED: apple-clang-6, apple-clang-7, apple-clang-8.0<br>
</span>+// XFAIL: libcpp-no-deduction-guides<br>
<div class="HOEnZb"><div class="h5"><br>
 // template<class InputIterator,<br>
 //      class Allocator = allocator<typename iterator_traits<InputIterator><wbr>::value_type>><br>
<br>
<br>
</div></div></blockquote></div><br></div>