<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 12 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Thanks! I’ll commit this.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Eric Christopher [mailto:echristo@gmail.com]
<br>
<b>Sent:</b> Wednesday, March 7, 2018 12:33 PM<br>
<b>To:</b> reviews+D44218+public+fd8ca19cc9985a1a@reviews.llvm.org<br>
<b>Cc:</b> cfe-commits@lists.llvm.org; craig.topper@gmail.com; erich.keane@intel.com; filcab+llvm.phabricator@gmail.com; Voss, Matthew; richard@metafoo.co.uk<br>
<b>Subject:</b> Re: [PATCH] D44218: Correct the alignment for the PS4 target<o:p></o:p></span></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">LGTM.<o:p></o:p></p>
<div>
<div>
<p class="MsoNormal">On Wed, Mar 7, 2018, 11:02 AM Matthew Voss via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-bottom:12.0pt">ormris created this revision.<br>
ormris added reviewers: rsmith, craig.topper, echristo, erichkeane.<br>
<br>
See above.<br>
<br>
<br>
Repository:<br>
rC Clang<br>
<br>
<a href="https://reviews.llvm.org/D44218" target="_blank">https://reviews.llvm.org/D44218</a><br>
<br>
Files:<br>
lib/Basic/Targets/OSTargets.h<br>
test/Preprocessor/init.c<br>
<br>
<br>
Index: test/Preprocessor/init.c<br>
===================================================================<br>
--- test/Preprocessor/init.c<br>
+++ test/Preprocessor/init.c<br>
@@ -8965,6 +8965,9 @@<br>
// PS4:#define __x86_64__ 1<br>
// PS4:#define unix 1<br>
//<br>
+// RUN: %clang_cc1 -x c++ -E -dM -ffreestanding -triple=x86_64-scei-ps4 < /dev/null | FileCheck -match-full-lines -check-prefix PS4-CXX %s<br>
+// PS4-CXX:#define __STDCPP_DEFAULT_NEW_ALIGNMENT__ 32UL<br>
+//<br>
// RUN: %clang_cc1 -E -dM -triple=x86_64-pc-mingw32 < /dev/null | FileCheck -match-full-lines -check-prefix X86-64-DECLSPEC %s<br>
// RUN: %clang_cc1 -E -dM -fms-extensions -triple=x86_64-unknown-mingw32 < /dev/null | FileCheck -match-full-lines -check-prefix X86-64-DECLSPEC %s<br>
// X86-64-DECLSPEC: #define __declspec{{.*}}<br>
Index: lib/Basic/Targets/OSTargets.h<br>
===================================================================<br>
--- lib/Basic/Targets/OSTargets.h<br>
+++ lib/Basic/Targets/OSTargets.h<br>
@@ -485,6 +485,7 @@<br>
default:<br>
case llvm::Triple::x86_64:<br>
this->MCountName = ".mcount";<br>
+ this->NewAlign = 256;<br>
break;<br>
}<br>
}<br>
<br>
<o:p></o:p></p>
</blockquote>
</div>
</div>
</body>
</html>