<div dir="auto">Awesome, thanks!</div><br><div class="gmail_quote"><div dir="ltr">On Sun, Mar 4, 2018, 11:26 AM Aaron Ballman via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: aaronballman<br>
Date: Sun Mar  4 08:24:10 2018<br>
New Revision: 326676<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=326676&view=rev" rel="noreferrer noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=326676&view=rev</a><br>
Log:<br>
Amend r326665 to print out the `used` attribute subjects in a different order.<br>
<br>
Modified:<br>
    cfe/trunk/include/clang/Basic/Attr.td<br>
    cfe/trunk/test/Sema/attr-used.c<br>
<br>
Modified: cfe/trunk/include/clang/Basic/Attr.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/Attr.td?rev=326676&r1=326675&r2=326676&view=diff" rel="noreferrer noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/Attr.td?rev=326676&r1=326675&r2=326676&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Basic/Attr.td (original)<br>
+++ cfe/trunk/include/clang/Basic/Attr.td Sun Mar  4 08:24:10 2018<br>
@@ -2010,7 +2010,7 @@ def Unused : InheritableAttr {<br>
<br>
 def Used : InheritableAttr {<br>
   let Spellings = [GCC<"used">];<br>
-  let Subjects = SubjectList<[Function, ObjCMethod, NonLocalVar]>;<br>
+  let Subjects = SubjectList<[NonLocalVar, Function, ObjCMethod]>;<br>
   let Documentation = [Undocumented];<br>
 }<br>
<br>
<br>
Modified: cfe/trunk/test/Sema/attr-used.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/attr-used.c?rev=326676&r1=326675&r2=326676&view=diff" rel="noreferrer noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/attr-used.c?rev=326676&r1=326675&r2=326676&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/Sema/attr-used.c (original)<br>
+++ cfe/trunk/test/Sema/attr-used.c Sun Mar  4 08:24:10 2018<br>
@@ -3,7 +3,7 @@<br>
 extern int l0 __attribute__((used)); // expected-warning {{'used' attribute ignored}}<br>
 __private_extern__ int l1 __attribute__((used)); // expected-warning {{'used' attribute ignored}}<br>
<br>
-struct __attribute__((used)) s { // expected-warning {{'used' attribute only applies to functions, Objective-C methods, and variables with non-local storage}}<br>
+struct __attribute__((used)) s { // expected-warning {{'used' attribute only applies to variables with non-local storage, functions, and Objective-C methods}}<br>
   int x;<br>
 };<br>
<br>
@@ -14,7 +14,7 @@ static void __attribute__((used)) f0(voi<br>
<br>
 void f1() {<br>
   static int a __attribute__((used));<br>
-  int b __attribute__((used)); // expected-warning {{'used' attribute only applies to functions, Objective-C methods, and variables with non-local storage}}<br>
+  int b __attribute__((used)); // expected-warning {{'used' attribute only applies to variables with non-local storage, functions, and Objective-C methods}}<br>
 }<br>
<br>
 static void __attribute__((used)) f0(void);<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" rel="noreferrer">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>