<div dir="ltr">Thanks! I knew there was something already, but I hadn't find it ;)</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Feb 2, 2018 at 2:23 PM, Benjamin Kramer via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Fri Feb  2 05:23:21 2018<br>
New Revision: 324079<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=324079&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=324079&view=rev</a><br>
Log:<br>
[clang-tidy] Don't reinvent the wheel, use existing log2 functions.<br>
<br>
This also makes the code ready for int128, even though I think it's<br>
currently impossible to get an int128 into this code path.<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/clang-<wbr>tidy/misc/<wbr>RedundantExpressionCheck.cpp<br>
<br>
Modified: clang-tools-extra/trunk/clang-<wbr>tidy/misc/<wbr>RedundantExpressionCheck.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/misc/RedundantExpressionCheck.cpp?rev=324079&r1=324078&r2=324079&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/clang-tools-extra/<wbr>trunk/clang-tidy/misc/<wbr>RedundantExpressionCheck.cpp?<wbr>rev=324079&r1=324078&r2=<wbr>324079&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- clang-tools-extra/trunk/clang-<wbr>tidy/misc/<wbr>RedundantExpressionCheck.cpp (original)<br>
+++ clang-tools-extra/trunk/clang-<wbr>tidy/misc/<wbr>RedundantExpressionCheck.cpp Fri Feb  2 05:23:21 2018<br>
@@ -966,13 +966,6 @@ void RedundantExpressionCheck::<wbr>checkRela<br>
   }<br>
 }<br>
<br>
-unsigned intLog2(uint64_t X) {<br>
-  unsigned Result = 0;<br>
-  while (X >>= 1)<br>
-    ++Result;<br>
-  return Result;<br>
-}<br>
-<br>
 void RedundantExpressionCheck::<wbr>check(const MatchFinder::MatchResult &Result) {<br>
   if (const auto *BinOp = Result.Nodes.getNodeAs<<wbr>BinaryOperator>("binary")) {<br>
     // If the expression's constants are macros, check whether they are<br>
@@ -1049,7 +1042,7 @@ void RedundantExpressionCheck::<wbr>check(con<br>
     // If ShiftingConst is shifted left with more bits than the position of the<br>
     // leftmost 1 in the bit representation of AndValue, AndConstant is<br>
     // ineffective.<br>
-    if (intLog2(AndValue.getExtValue(<wbr>)) >= ShiftingValue)<br>
+    if (AndValue.getActiveBits() > ShiftingValue)<br>
       return;<br>
<br>
     auto Diag = diag(BinaryAndExpr-><wbr>getOperatorLoc(),<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>