<div dir="ltr">Any chance of making this a really low priority completion? (maybe just leaving in a FIXME or expected-fail check of some kind if it's not practical to implement it right now) For those handful of times when you actually want to do this.</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Jan 22, 2018 at 1:06 PM Sam McCall via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: sammccall<br>
Date: Mon Jan 22 13:05:00 2018<br>
New Revision: 323149<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=323149&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=323149&view=rev</a><br>
Log:<br>
[clangd] Drop ~destructor completions - rarely helpful and work inconsistently<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/clangd/CodeComplete.cpp<br>
    clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp<br>
<br>
Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/CodeComplete.cpp?rev=323149&r1=323148&r2=323149&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/CodeComplete.cpp?rev=323149&r1=323148&r2=323149&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clangd/CodeComplete.cpp (original)<br>
+++ clang-tools-extra/trunk/clangd/CodeComplete.cpp Mon Jan 22 13:05:00 2018<br>
@@ -361,6 +361,10 @@ struct CompletionRecorder : public CodeC<br>
           (Result.Availability == CXAvailability_NotAvailable ||<br>
            Result.Availability == CXAvailability_NotAccessible))<br>
         continue;<br>
+      // Destructor completion is rarely useful, and works inconsistently.<br>
+      // (s.^ completes ~string, but s.~st^ is an error).<br>
+      if (dyn_cast_or_null<CXXDestructorDecl>(Result.Declaration))<br>
+        continue;<br>
       Results.push_back(Result);<br>
     }<br>
   }<br>
<br>
Modified: clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp?rev=323149&r1=323148&r2=323149&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp?rev=323149&r1=323148&r2=323149&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp (original)<br>
+++ clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp Mon Jan 22 13:05:00 2018<br>
@@ -461,7 +461,7 @@ TEST(CompletionTest, NoDuplicates) {<br>
       {cls("Adapter")});<br>
<br>
   // Make sure there are no duplicate entries of 'Adapter'.<br>
-  EXPECT_THAT(Results.items, ElementsAre(Named("Adapter"), Named("~Adapter")));<br>
+  EXPECT_THAT(Results.items, ElementsAre(Named("Adapter")));<br>
 }<br>
<br>
 TEST(CompletionTest, ScopedNoIndex) {<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>