<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Jan 25, 2018 at 12:29 PM, Duncan P. N. Exon Smith <span dir="ltr"><<a href="mailto:dexonsmith@apple.com" target="_blank">dexonsmith@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div></div><div><div>I don't really understand why, but our bots seemed to survive this:</div><div><a href="http://lab.llvm.org:8080/green/view/Libcxx/job/libcxx_master_cmake/2137/" target="_blank">http://lab.llvm.org:8080/<wbr>green/view/Libcxx/job/libcxx_<wbr>master_cmake/2137/</a></div><div><br></div><div>Console output is here:</div><div><a href="http://lab.llvm.org:8080/green/view/Libcxx/job/libcxx_master_cmake/2137/consoleFull" target="_blank">http://lab.llvm.org:8080/<wbr>green/view/Libcxx/job/libcxx_<wbr>master_cmake/2137/consoleFull</a></div><div><br></div><div>That doesn't necessarily mean it's safe.  Does anyone know why this might have "worked"?</div></div></div></blockquote><div><br></div><div>I'm not an expert, but llvm installs all of these cmake modules along side llvm-config, so if you find llvm-config, you find these modules.</div><div><br></div><div>So, unless I'm missing something, it looks like AddLLVM.cmake is always available.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div><div><div class="h5"><div><br><blockquote type="cite"><div>On Jan 25, 2018, at 11:02, Shoaib Meenai <<a href="mailto:smeenai@fb.com" target="_blank">smeenai@fb.com</a>> wrote:</div><br class="m_4857861198779353090Apple-interchange-newline"><div><div class="m_4857861198779353090WordSection1" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255)"><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif">This is going to break building libc++ standalone (i.e. without any LLVM repository or even its CMake modules), right? Some upstream users care a lot about that use case (CC beanz and Duncan).<u></u><u></u></div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div><div style="border-style:solid none none;border-top-width:1pt;border-top-color:rgb(181,196,223);padding:3pt 0in 0in"><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif"><b><span style="font-size:12pt">From:<span class="m_4857861198779353090Apple-converted-space"> </span></span></b><span style="font-size:12pt">cfe-commits <<a href="mailto:cfe-commits-bounces@lists.llvm.org" style="color:purple;text-decoration:underline" target="_blank">cfe-commits-bounces@lists.<wbr>llvm.org</a>> on behalf of Don Hinton via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" style="color:purple;text-decoration:underline" target="_blank">cfe-commits@lists.llvm.org</a>><br><b>Reply-To:<span class="m_4857861198779353090Apple-converted-space"> </span></b>Don Hinton <<a href="mailto:hintonda@gmail.com" style="color:purple;text-decoration:underline" target="_blank">hintonda@gmail.com</a>><br><b>Date:<span class="m_4857861198779353090Apple-converted-space"> </span></b>Thursday, January 25, 2018 at 10:15 AM<br><b>To:<span class="m_4857861198779353090Apple-converted-space"> </span></b>"<a href="mailto:cfe-commits@lists.llvm.org" style="color:purple;text-decoration:underline" target="_blank">cfe-commits@lists.llvm.<wbr>org</a>" <<a href="mailto:cfe-commits@lists.llvm.org" style="color:purple;text-decoration:underline" target="_blank">cfe-commits@lists.llvm.org</a>><br><b>Subject:<span class="m_4857861198779353090Apple-converted-space"> </span></b>[libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.<u></u><u></u></span></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">Author: dhinton<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">Date: Thu Jan 25 10:13:26 2018<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">New Revision: 323453<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">URL:<span class="m_4857861198779353090Apple-converted-space"> </span><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D323453-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=zwvSmk9ZIfMARYg3JvYvNuA0Iz-PEq3H2i_ICF6vsR8&s=LDCu89byjNdZWoCIYHGHaPr3IamIdHLF0JwbnYE92vM&e=" style="color:purple;text-decoration:underline" target="_blank">https://urldefense.<wbr>proofpoint.com/v2/url?u=http-<wbr>3A__llvm.org_viewvc_llvm-<wbr>2Dproject-3Frev-3D323453-<wbr>26view-3Drev&d=DwIGaQ&c=<wbr>5VD0RTtNlTh3ycd41b3MUw&r=<wbr>o3kDXzdBUE3ljQXKeTWOMw&m=<wbr>zwvSmk9ZIfMARYg3JvYvNuA0Iz-<wbr>PEq3H2i_ICF6vsR8&s=<wbr>LDCu89byjNdZWoCIYHGHaPr3IamIdH<wbr>LF0JwbnYE92vM&e=</a><u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">Log:<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">[cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">Clang and llvm already use llvm_setup_rpath(), so this change will<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">help standarize rpath usage across all projects.<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">Differential Revision:<span class="m_4857861198779353090Apple-converted-space"> </span><a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D42459&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=zwvSmk9ZIfMARYg3JvYvNuA0Iz-PEq3H2i_ICF6vsR8&s=YCR-YJBua5p-4IK05GjHoZUU7aN8UJAFzL2xaz7byyw&e=" style="color:purple;text-decoration:underline" target="_blank">https://urldefense.<wbr>proofpoint.com/v2/url?u=https-<wbr>3A__reviews.llvm.org_D42459&d=<wbr>DwIGaQ&c=<wbr>5VD0RTtNlTh3ycd41b3MUw&r=<wbr>o3kDXzdBUE3ljQXKeTWOMw&m=<wbr>zwvSmk9ZIfMARYg3JvYvNuA0Iz-<wbr>PEq3H2i_ICF6vsR8&s=YCR-<wbr>YJBua5p-<wbr>4IK05GjHoZUU7aN8UJAFzL2xaz7byy<wbr>w&e=</a><u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">Modified:<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">    libcxx/trunk/lib/<wbr>CMakeLists.txt<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">Modified: libcxx/trunk/lib/CMakeLists.<wbr>txt<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">URL:<span class="m_4857861198779353090Apple-converted-space"> </span><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_libcxx_trunk_lib_CMakeLists.txt-3Frev-3D323453-26r1-3D323452-26r2-3D323453-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=zwvSmk9ZIfMARYg3JvYvNuA0Iz-PEq3H2i_ICF6vsR8&s=Rd7xc2GWS8oyDcm0QshNPTqM3BglPY5_aHMIuCRUt1s&e=" style="color:purple;text-decoration:underline" target="_blank">https://urldefense.<wbr>proofpoint.com/v2/url?u=http-<wbr>3A__llvm.org_viewvc_llvm-<wbr>2Dproject_libcxx_trunk_lib_<wbr>CMakeLists.txt-3Frev-3D323453-<wbr>26r1-3D323452-26r2-3D323453-<wbr>26view-3Ddiff&d=DwIGaQ&c=<wbr>5VD0RTtNlTh3ycd41b3MUw&r=<wbr>o3kDXzdBUE3ljQXKeTWOMw&m=<wbr>zwvSmk9ZIfMARYg3JvYvNuA0Iz-<wbr>PEq3H2i_ICF6vsR8&s=<wbr>Rd7xc2GWS8oyDcm0QshNPTqM3BglPY<wbr>5_aHMIuCRUt1s&e=</a><u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">==============================<wbr>==============================<wbr>==================<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">--- libcxx/trunk/lib/CMakeLists.<wbr>txt (original)<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">+++ libcxx/trunk/lib/CMakeLists.<wbr>txt Thu Jan 25 10:13:26 2018<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">@@ -222,6 +222,7 @@ set(LIBCXX_TARGETS)<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif"># Build the shared library.<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">if (LIBCXX_ENABLE_SHARED)<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">   add_library(cxx_shared SHARED $<TARGET_OBJECTS:cxx_objects>)<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">+  llvm_setup_rpath(cxx_<wbr>shared)<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">   target_link_libraries(cxx_<wbr>shared ${LIBCXX_LIBRARIES})<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">   set_target_properties(cxx_<wbr>shared<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">     PROPERTIES<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">______________________________<wbr>_________________<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif">cfe-commits mailing list<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif"><a href="mailto:cfe-commits@lists.llvm.org" style="color:purple;text-decoration:underline" target="_blank">cfe-commits@lists.llvm.org</a><u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif"><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=zwvSmk9ZIfMARYg3JvYvNuA0Iz-PEq3H2i_ICF6vsR8&s=TPt8bk99XfmUCdi7MBxyguYV6hJg3PsXFCTXyDfGms8&e=" style="color:purple;text-decoration:underline" target="_blank">https://urldefense.proofpoint.<wbr>com/v2/url?u=http-3A__lists.<wbr>llvm.org_cgi-2Dbin_mailman_<wbr>listinfo_cfe-2Dcommits&d=<wbr>DwIGaQ&c=<wbr>5VD0RTtNlTh3ycd41b3MUw&r=<wbr>o3kDXzdBUE3ljQXKeTWOMw&m=<wbr>zwvSmk9ZIfMARYg3JvYvNuA0Iz-<wbr>PEq3H2i_ICF6vsR8&s=<wbr>TPt8bk99XfmUCdi7MBxyguYV6hJg3P<wbr>sXFCTXyDfGms8&e=</a><u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div></div></div></div></blockquote></div><br></div></div></div></div></blockquote></div><br></div></div>