<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi,<div class=""><br class=""></div><div class="">Looks like the test is failing on MacOS [1]. Could you please take a look?</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Michael</div><div class=""><br class=""></div><div class="">[1] <a href="http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/45726/consoleFull#9955924438254eaf0-7326-4999-85b0-388101f2d404" class="">http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/45726/consoleFull#9955924438254eaf0-7326-4999-85b0-388101f2d404</a></div><div class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jan 17, 2018, at 2:09 PM, Ana Pazos via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Author: apazos<br class="">Date: Wed Jan 17 14:09:58 2018<br class="">New Revision: 322769<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=322769&view=rev" class="">http://llvm.org/viewvc/llvm-project?rev=322769&view=rev</a><br class="">Log:<br class="">[RISCV] Propagate -mabi and -march values to GNU assembler.<br class=""><br class="">When using -fno-integrated-as flag, the gnu assembler produces code<br class="">with some default march/mabi which later causes linker failure due<br class="">to incompatible mabi/march.<br class=""><br class="">In this patch we explicitly propagate -mabi and -march flags to the<br class="">GNU assembler.<br class=""><br class="">In this patch we explicitly propagate -mabi and -march flags to the GNU assembler.<br class=""><br class="">Differential Revision: <a href="https://reviews.llvm.org/D41271" class="">https://reviews.llvm.org/D41271</a><br class=""><br class="">Added:<br class=""> cfe/trunk/test/Driver/Inputs/multilib_riscv_linux_sdk/riscv64-unknown-linux-gnu/bin/as<br class=""> cfe/trunk/test/Driver/riscv-gnutools.c<br class="">Modified:<br class=""> cfe/trunk/lib/Driver/ToolChains/Gnu.cpp<br class=""><br class="">Modified: cfe/trunk/lib/Driver/ToolChains/Gnu.cpp<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/Gnu.cpp?rev=322769&r1=322768&r2=322769&view=diff" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/Gnu.cpp?rev=322769&r1=322768&r2=322769&view=diff</a><br class="">==============================================================================<br class="">--- cfe/trunk/lib/Driver/ToolChains/Gnu.cpp (original)<br class="">+++ cfe/trunk/lib/Driver/ToolChains/Gnu.cpp Wed Jan 17 14:09:58 2018<br class="">@@ -629,6 +629,18 @@ void tools::gnutools::Assembler::Constru<br class=""> ppc::getPPCAsmModeForCPU(getCPUName(Args, getToolChain().getTriple())));<br class=""> break;<br class=""> }<br class="">+ case llvm::Triple::riscv32:<br class="">+ case llvm::Triple::riscv64: {<br class="">+ StringRef ABIName = riscv::getRISCVABI(Args, getToolChain().getTriple());<br class="">+ CmdArgs.push_back("-mabi");<br class="">+ CmdArgs.push_back(ABIName.data());<br class="">+ if (const Arg *A = Args.getLastArg(options::OPT_march_EQ)) {<br class="">+ StringRef MArch = A->getValue();<br class="">+ CmdArgs.push_back("-march");<br class="">+ CmdArgs.push_back(MArch.data());<br class="">+ }<br class="">+ break;<br class="">+ }<br class=""> case llvm::Triple::sparc:<br class=""> case llvm::Triple::sparcel: {<br class=""> CmdArgs.push_back("-32");<br class=""><br class="">Added: cfe/trunk/test/Driver/Inputs/multilib_riscv_linux_sdk/riscv64-unknown-linux-gnu/bin/as<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/Inputs/multilib_riscv_linux_sdk/riscv64-unknown-linux-gnu/bin/as?rev=322769&view=auto" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/Inputs/multilib_riscv_linux_sdk/riscv64-unknown-linux-gnu/bin/as?rev=322769&view=auto</a><br class="">==============================================================================<br class="">--- cfe/trunk/test/Driver/Inputs/multilib_riscv_linux_sdk/riscv64-unknown-linux-gnu/bin/as (added)<br class="">+++ cfe/trunk/test/Driver/Inputs/multilib_riscv_linux_sdk/riscv64-unknown-linux-gnu/bin/as Wed Jan 17 14:09:58 2018<br class="">@@ -0,0 +1 @@<br class="">+#!/bin/true<br class=""><br class="">Added: cfe/trunk/test/Driver/riscv-gnutools.c<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/riscv-gnutools.c?rev=322769&view=auto" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/riscv-gnutools.c?rev=322769&view=auto</a><br class="">==============================================================================<br class="">--- cfe/trunk/test/Driver/riscv-gnutools.c (added)<br class="">+++ cfe/trunk/test/Driver/riscv-gnutools.c Wed Jan 17 14:09:58 2018<br class="">@@ -0,0 +1,14 @@<br class="">+// Check gnutools are invoked with propagated values for -mabi and -march.<br class="">+<br class="">+// RUN: %clang -target riscv32-linux-unknown-elf -fno-integrated-as \<br class="">+// RUN: --gcc-toolchain=%S/Inputs/multilib_riscv_linux_sdk \<br class="">+// RUN: --sysroot=%S/Inputs/multilib_riscv_linux_sdk/sysroot %s -### \<br class="">+// RUN: 2>&1 | FileCheck -check-prefix=MABI-ILP32 %s<br class="">+// RUN: %clang -target riscv32-linux-unknown-elf -fno-integrated-as \<br class="">+// RUN: -march=rv32g --gcc-toolchain=%S/Inputs/multilib_riscv_linux_sdk \<br class="">+// RUN: --sysroot=%S/Inputs/multilib_riscv_linux_sdk/sysroot %s -### \<br class="">+// RUN: 2>&1 | FileCheck -check-prefix=MABI-ILP32-MARCH-G %s<br class="">+<br class="">+// MABI-ILP32: "{{.*}}/Inputs/multilib_riscv_linux_sdk/lib/gcc/riscv64-unknown-linux-gnu/7.2.0/../../../../riscv64-unknown-linux-gnu/bin{{/|\\\\}}as" "-mabi" "ilp32"<br class="">+// MABI-ILP32-MARCH-G: "{{.*}}/Inputs/multilib_riscv_linux_sdk/lib/gcc/riscv64-unknown-linux-gnu/7.2.0/../../../../riscv64-unknown-linux-gnu/bin{{/|\\\\}}as" "-mabi" "ilp32" "-march" "rv32g"<br class="">+<br class=""><br class=""><br class="">_______________________________________________<br class="">cfe-commits mailing list<br class=""><a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits<br class=""></div></div></blockquote></div><br class=""></div></body></html>